Address substrate-gke installer feedback: AR API, teardown coverage, doc fix - #1408
Merged
Anna Pendleton (annapendleton) merged 4 commits intoSep 2, 2026
Conversation
Bootstrap grants roles/artifactregistry.reader to the GKE node service account and the atelet workload-identity principal, and ko pushes the control-plane images through gcr.io's Artifact Registry backing — but the API-enablement step never enabled artifactregistry.googleapis.com, so a fresh project failed at image push/pull instead of step 1.
- Revoke atelet's project-level bindings (roles/storage.objectAdmin and roles/artifactregistry.reader for the workload-identity principal), which grant_atelet_permissions adds but nothing removed. - Delete the three Substrate monitoring dashboards, matched by the display names in tools/setup-gcp/dashboards/. - Accept configuration from the environment when .ate-dev-env.sh is absent, so installers and one-liners can drive the script, and fail with the specific missing variable instead of a blanket message. - Drop the kubectl cluster-admin precheck: every step talks to GCP, not the cluster, and the check blocked tearing down a cluster that was already gone or unreachable. - Make --all run in the true reverse of bootstrap's setup order.
The closing paragraph claimed the per-demo hack scripts are gone, but hack/install-ate.sh still sources hack/install-demo-*.sh and generates its --deploy-demo-NAME / --delete-demo-NAME flags from them. Describe the two installers as parallel instead of declaring one dead.
This was referenced Sep 2, 2026
Deleting a bucket must not demand a node pool name. Each step now declares its own requirements via a require helper, still failing up front with the specific missing variable, and --all skips the separate node-pool deletion when NODE_POOL_NAME is unset — deleting the cluster removes its pools — so a caller that does not track the pool name (an installer driving this script through the environment) can still run the full teardown.
Collaborator
Author
|
Pushed one more commit: the env-var guard now lives per step ( |
Anna Pendleton (annapendleton)
approved these changes
Sep 2, 2026
Anna Pendleton (annapendleton)
merged commit Sep 2, 2026
cbae825
into
agent-substrate:main
9 checks passed
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from user feedback on the substrate-gke installer experience, consolidated per reviewer preference (replaces #1405, #1406, #1407):
1. setup-gcp: enable
artifactregistry.googleapis.comin bootstrap. Bootstrap grantsroles/artifactregistry.readerto the GKE node service account and the atelet workload-identity principal, and ko pushes the control-plane images through gcr.io's Artifact Registry backing — butenableRequiredAPIsnever enabled the API, so a fresh project failed at image push/pull instead of step 1.2. teardown.sh: cover everything bootstrap creates, without a dev-env file.
roles/storage.objectAdmin,roles/artifactregistry.reader), whichgrant_atelet_permissionsadds but nothing removed.tools/setup-gcp/dashboards/..ate-dev-env.shis absent (missing variables are named specifically), so installers and one-liners can drive the script.--allnow runs in the true reverse of bootstrap's setup order.3. commands.md: the
hack/install-demo-*.shscripts still exist. The closing paragraph claimed they are gone, buthack/install-ate.shstill sources them and generates its--deploy-demo-NAME/--delete-demo-NAMEflags from them.