temporarily drop device support - #1389
Merged
Tim Hockin (thockin) merged 2 commits intoSep 2, 2026
Merged
Conversation
containerd applies CDI to a pod's containers, and actor containers sit underneath one, so whatever gives an actor a device reads the spec itself. Split by how far it travels: internal/cdi parses a spec and resolves what a named set of devices asks for, which any sandbox can use, while cmd/ateom-gvisor/internal/cdiinject applies the result to a bundle on disk and stats the host for device numbers, which only suits a sandbox on the host kernel. The NVIDIA specifics -- which devices, which hooks may run, which library directories -- are caller options rather than package globals. No behavior change, and the tests run on any host rather than Linux only.
A GPU worker pool injected its devices into every container of every actor on it, which only held up while a worker ran one actor. A resource name and a count cannot replace it: that shape cannot express which container gets a device, sharing one between containers, or resuming onto hardware compatible with the snapshot. A nvidia.com/gpu pool limit is now an ordinary extended resource -- it places the pod on a GPU node and nothing else reads it. internal/cdi stays, unused: whatever the API becomes, an ateom still has to merge CDI edits into an actor's bundle itself.
Collaborator
|
Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #752 (comment)
TLDR: I think we need to rethink how we express devices.
This PR drops the user facing support, while retaining some other bits around CDI for-reuse when we're ready.