benchmarking: Refactor boomer based Locust benchmarking - #1295
Merged
Zoe Zhao (zoez7) merged 3 commits intoSep 2, 2026
Merged
Conversation
pmandewalkar
force-pushed
the
refactor-boomer-benchmarking
branch
2 times, most recently
from
September 1, 2026 19:09
5ddad6d to
42cabaf
Compare
pmandewalkar
changed the title
pmandewalkar
force-pushed
the
refactor-boomer-benchmarking
branch
from
September 1, 2026 22:44
42cabaf to
fb02e69
Compare
Haowei Cai (Roy) (roycaihw)
approved these changes
Sep 1, 2026
| "github.com/agent-substrate/substrate/internal/benchmarking/boomer/boomerutil" | ||
| "github.com/agent-substrate/substrate/internal/benchmarking/boomer/dynconfig" | ||
| "github.com/agent-substrate/substrate/internal/benchmarking/boomer/glutton" | ||
| _ "github.com/agent-substrate/substrate/internal/benchmarking/boomer/glutton" |
There was a problem hiding this comment.
Is it still needed (e.g. doing some package level init)? If not, let's remove this import.
Collaborator
There was a problem hiding this comment.
lifecycle.go has an init function.
I think it might make sense to include init imports in their own commented import block.
| // ateapi rejects calls that carry no credential, so present the pod | ||
| // certificate — the same client auth the base install gives ate-controller | ||
| // and atenet-router. ClientCredBundle re-reads the bundle on every handshake, | ||
| // so rotations are picked up without a restart. |
There was a problem hiding this comment.
Let's keep the documentation. Maybe this gets dropped accidentally during a rebase?
|
cc Max Smythe (@maxsmythe) PTAL |
Max Smythe (maxsmythe)
requested changes
Sep 2, 2026
Max Smythe (maxsmythe)
left a comment
Max Smythe (maxsmythe)
left a comment
Collaborator
There was a problem hiding this comment.
After two small nits, LGTM
pmandewalkar
force-pushed
the
refactor-boomer-benchmarking
branch
from
September 2, 2026 17:37
fb02e69 to
1b4fa72
Compare
pmandewalkar
force-pushed
the
refactor-boomer-benchmarking
branch
from
September 2, 2026 18:04
1b4fa72 to
02cd850
Compare
pmandewalkar
requested review from
Max Smythe (maxsmythe) and
Haowei Cai (Roy) (roycaihw)
September 2, 2026 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1248
Renamed boomer-glutton to boomer-worker.
Extracted the boomer shared utils that future non-glutton workloads may use to the boomerutil package.
Updated durdir and glutton to import and use the changes.