fix(demo): update routing and deploy script for GKE Substrate deployment - #1
Conversation
|
Hi Mofi Rahman (@moficodes) ! Thanks for picking this up! I tested it on two clusters running the release-0.1 build the demo README pins (c48b3a3c), and it doesn't work there yet. The So I think it's one of these:
I'd lean toward the second, since release-0.1 is what people will install from the README. A few smaller things:
Let me know if it'd help to pair on the dual-mode version! |
Send actor requests with both the Host and ate-target-actor header, fall back from --template-ref to --template, and fix the deploy and dashboard issues raised in review.
|
Went with the second option. 88a9ffb makes it work on both release-0.1 and main:
Tested on two clusters:
One thing on main that this PR doesn't fix: since substrate f980a57d, actors have no egress unless they have an EgressPolicy, so the actor on main can't reach Gemini and turns come back empty. Routing works. We will need to fix that for this demo. |
Maya Wang (mayawang)
left a comment
There was a problem hiding this comment.
LGTM, thanks for going the dual-mode route and testing on both! Sending both the Host and the header is a nice clean fix.
For the egress gap on main, want to open an issue for it so we can track it separately? Happy to help sort out the EgressPolicy side.
<actor>.<atespace>.actors.resources.substrate.ate.devwith an explicit HTTP header:ate-target-actor: <atespace>/<actor>.The demo was not working without these change.
These changes are backward compatible so no existing substrate deployment should fail with these, but newer substrate deployment will not work without these changes.