fix(version): don't mark a stamped release build as -dirty#23
Merged
Conversation
The release pipeline stamps package.json (0.1.3 → tag version) before building, which dirties the working tree, so `git describe --tags --dirty` baked `X.Y.Z-dirty` into a clean published release (e.g. quoin --version printed 0.5.3-dirty). Drop --dirty: HEAD-on-tag now bakes the bare tag, while a build ahead of its tag still shows the commits-ahead `-N-gsha` drift suffix. Update FR-002 accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (caught by dogfooding)
quoin --versionprinted0.5.3-dirtyfor the clean published release. Cause: the release pipeline stampspackage.json(0.1.3 → tag version) beforeprepublishOnlybuilds, dirtying the tree, sogit describe --tags --dirtybaked the-dirtysuffix.Fix
Drop
--dirty.git describe --tagsignores working-tree state: HEAD-on-a-tag → bare tag (0.5.4); a build ahead of its tag →0.5.3-2-gabc123(drift still revealed). FR-002 updated to match.Verified: local build on the v0.5.3 commit now bakes
0.5.3(was0.5.3-dirty).🤖 Generated with Claude Code