Updated Deprecated on_event in Starlette 1.0#150
Merged
hubert-marek merged 2 commits intomainfrom Apr 17, 2026
Merged
Conversation
- Convert the shutdown hook to a lifespan context manager so uvicorn boots on Starlette 1.0 (the decorator-based ``on_event`` hook was removed in that release and crashed ``create_app`` at import time). - Add ``github`` to the ``Service`` enum so ``initEnv`` accepts the GitHub templates that were landed alongside the service package. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
Add it as step 5 in the "Adding a New Service" section so future service authors don't forget to widen the Pydantic enum — skipping it leaves initEnv returning a validation error even after the router is mounted and templates are seeded. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hubert-marek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_eventhook was removed in that release and crashedcreate_appat import time).