fix: rename input pre-fills the session title and selects all text - #357
Open
windli2018 wants to merge 1 commit into
Open
fix: rename input pre-fills the session title and selects all text#357windli2018 wants to merge 1 commit into
windli2018 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When renaming a session, the rename input now pre-fills the displayed title and selects all of it — so you can type a new name to replace it, or edit in place.
Why
Before, the input was pre-filled with
session.nameonly. Sessions without an explicit name (most of them) have an emptysession.name, so the input appeared blank — even though the sidebar displays a fallback title (first message / id). Also the pre-select ran viasetTimeout(..., 0)before the input had mounted, so it often didn't select anything.How
startRenamefillssession.name || firstMessage.slice(0,50) || id.slice(0,12)(the same fallback the row title uses).useEffectonrenaming(after the input is mounted, viarequestAnimationFrame).commitRenameno-ops when the value equals the displayed fallback title — so the fallback isn't accidentally persisted as a real name.Validation