feat: browser notification when agent session ends - #356
Open
xCss wants to merge 1 commit into
Open
Conversation
Closes agegr#339. Ref discussion agegr#317. When the tab is in the background, fires a Web Notifications API popup on agent completion. The notification title uses the current session name (falls back to i18n "Session complete"); the body is the i18n "Task finished." string, so both en and zh-CN are covered. Permission is requested lazily on the first background completion; denied or unsupported browsers are silently skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339. Ref discussion #317.
What
When the browser tab is in the background, a Web Notifications API popup fires when the agent finishes responding.
Behavior
Implementation
Single change to
handleAgentEndinAppShell.tsx(~15 lines). i18n keys added toen.tsandzh-CN.ts.i18n.sessionCompletei18n.taskFinishedScreenshot