Closed
Fix stale roomCodeInput and autoJoinedRef when navigating between rooms#7
Conversation
Merged
Co-authored-by: afraser <1179515+afraser@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on routing and testing in PR #4
Fix stale roomCodeInput and autoJoinedRef when navigating between rooms
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PeerViewreuses its component instance when navigating between/listen/:roomIdroutes, leavingroomCodeInputshowing the previous room code andautoJoinedRefpermanentlytrue, preventing auto-join from firing for subsequent rooms.Changes
PeerView.jsxinitialRoomCode→roomId(live value fromuseParams)useEffectonroomIdthat resets all relevant state and closes any activeRTCPeerConnectionon navigation:roomIddirectly instead of the stale captured valuePeerView.test.jsxSHARED_ROUTESconstantrenderPeerViewWithNavhelper (injects aNavButtonscomponent intoMemoryRouterto drive navigation withoutcreateMemoryRouter, which has anAbortSignalincompatibility with jsdom in RR v7)roomIdresets the input and fires a fresh auto-join; navigating to/join-roomclears the input🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.