[WIP] Added gallery prototype for browsing scenes#154
Open
JonathanZWhite wants to merge 1 commit intoaframevr:masterfrom
Open
[WIP] Added gallery prototype for browsing scenes#154JonathanZWhite wants to merge 1 commit intoaframevr:masterfrom
JonathanZWhite wants to merge 1 commit intoaframevr:masterfrom
Conversation
Member
|
awesome, pretty impressive with the VR UI interactions. will come back to this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prototype for a gallery inside of A-Painter. This code is a rough sketch for the interactions and technical implementation for a way of browsing scenes. I want to get some feedback on whether or not this is a good/mergeable idea before fleshing out the code more.
The gallery can accessed by going adding the
gallery=truequery param. Most of the new code is in gallery-controls.js.As of right now, the gallery can be controlled by the up, down, and enter arrow keys. However, I've already started investigating adding basic support for Vive controllers. In addition, using a carousel isn't the only feasible UI. It seems like it would be feasible to add use a UI similar to the Sketch Book in TiltBrush.
Feedback and comments appreciated 😄