Repository navigation
Check downloaded release assets before publication - #18
Merged
Merged
Conversation
afflom
marked this pull request as ready for review
November 16, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release publication previously followed the build without testing downloaded bytes. This change makes publication depend on a shared, read-only consumer job that validates the mathematical inventory, flat regular-file paths, complete checksum coverage, PDF aliases and readable verified archives. All mathematical assets and proof gates remain intact.
Main CI now produces a complete candidate immediately after its unchanged acceptance gate, using exact tool/input-keyed gate evidence and the existing package-only command. A checksum-covered candidate.json binds the accepted checkout commit/tree, repository, run ID and attempt. A downstream job downloads the same-run artifact without checkout, rendering, extraction or artifact execution. On PRs the accepted checkout is GitHub's merge commit, not the branch head. Missing identity data fails closed. Rerun all jobs after failure: a new attempt requires its own candidate artifact. No extra full gate, tag, release or write permission is introduced for this transport check.
The v0.2 native inventory remains provisional. Its publication guard must be replaced only in the reviewed integration connecting owner-confirmed native outputs to successful consumer qualification. No manual readiness flag is provided. Platform/proof limitations and Problem 1's unproved status remain explicit; #8 Holo is a later distribution opportunity.
Passed evidence:
Current head ff21452 committed through unchanged hooks using official Lean 4.32.2 and pinned LexLean 9fd01c31e40bb29577833825f902fafcceedb49a.
243 tooling tests passed with four skips (absent certified production bundles/headless Chromium); unchanged build, replay/axiom audits, packaging and mirror checks passed. Exact accepted core, paper and API LexLean evidence was reused. Pre-push reused accepted tree f4f33dd67947.
28 focused tests execute the actual consumer workflow code: valid candidate/identity, missing or mismatched identity fields, missing required assets, corruption, extra/duplicate checksum records, unsafe paths, symlinks/directories, alias mismatch and invalid archives.
Local producer integration packaged a complete 18-file candidate from retained accepted fa972e0 evidence in an isolated clone; actual consumer shell passed. Wrong checkout and existing evidence destination were rejected. These are local results, not hosted download evidence.
Independent implementation review found no remaining blockers after fixing missing-tree conditional bypass. Normal hooks refreshed PDF derivatives and pdf-manifest.json; TeX hashes are unchanged.
Prior ordinary CI run 43911460474 passed at fa972e0. It did not execute the new consumer path.
Current-head hosted run 43942564272 completed successfully for ff21452. Build and Validate (No Publish), candidate packaging/upload, and the separate Check accepted candidate download job all passed, including required assets/downloaded bytes and accepted-run identity. This is actual hosted mathematical candidate transport validation, not public GitHub Release download or native qualification.
Complete candidate artifact: rule30-release-candidate-1, ID 14265375136, 20,356,518 bytes, GitHub archive digest sha256:7f18bb6d881417dc1d2f7ca59c1d597d9fada33e4911b0068c0258ba2ac8fe1a. Artifact metadata binds run 43942564272 and the current branch head.
Independent final scope review at ff21452 passed: authored files match the reviewed implementation; nine PDF copies and pdf-manifest.json are the only generated refresh; PDF aliases match manifest hashes; TeX hashes are unchanged; no native/intake/coordinator/proof-source edits. No review blockers remain in this scoped increment.
Pending:
Integration completed: independently reviewed head ff21452 was promoted and merged as cf8b992 after successful hosted run 43942564272. The merged main tree has no file differences from the accepted head (tree f4f33dd67947a0b92856ede19065142ee30994ff). The native v0.2 publication guard remains intact; no release completion is claimed.
Authored scope: .github/workflows/{main-ci,release,download-check}.yml, .github/tests/release-consumer.test.cjs, README.md and docs/releases/v0.2.md. No coordinator/intake sources, production requests, proof fixtures, hooks or proof policies changed. Historical denied transfers and originals remain untouched.