Repository navigation
One file per guest; the train runs the browser acceptances and says why it waits - #164
Conversation
Every new guest appended to app/specs/guests/spec.json, lock.json and generators/guests/steps.json, so guest pull requests conflicted with each other there. Each guest is now app/specs/guests/<facet>/<id>.json with its lock beside it as <id>.lock.json, and each guest step is its own file under generators/guests/steps/. tools/guests/gen.py and the LexLean pin generator (GenGuests, rebuilt) read those; run.sh reads a program's steps/*.json. The guests of a loader are now listed in id order. Merge train: a pull request whose required check ended without passing (cancelled at the time limit, say) was skipped without a word. The train now says so once for that head. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ
…-jbqzew # Conflicts: # app/specs/guests/lock.json # app/specs/guests/spec.json # generators/guests/steps.json
|
Merge train notice: the merge train merges this pull request once it is green on current main; don't enable auto-merge. Generated by Claude Code |
The train ran the fast gates on each pull request merged with main, but the browser acceptances only ran on each pull request alone. #145 and #161 were each green and main then failed CO-01 and the timing budgets. After the fast gates pass, the train now builds a holo from the merged tree (no proof: main's own run binds that), assembles the page as the page job does, and runs every test/*/run.mjs and every *.test.mjs once. It does this in a git worktree, so the train's tree stays what it merges, and in a shell of its own, because bash ignores errexit inside an if. The test job's limit goes from 90 to 240 minutes. Tried locally end to end: the holo builds, the page assembles and all 281 tests run in about 13 minutes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ
|
Status of this pull request:
Generated by Claude Code |
#145 more than doubled labeling-ms-per-100 (about 100 to about 240, limit 250) and merged on one lucky sample. A cold start happens once in a process, so the test times two more in processes of their own and holds the slowest to the threshold. The quality record says so. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ
…-jbqzew Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ
…-jbqzew Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ
|
Merge train: f2303ee: not merged, because it conflicts with main (7871266) and the pull requests the train takes before it. Fix it on this branch (merge main first) and the train tests it again. Generated by Claude Code |
|
Main itself failed its last finished deploy on 7871266 with QR-30 journeys-broken, which is the class the train step in this pull request closes. Merged main again (85954b6); checks are running. Generated by Claude Code |
|
Live: this change is on the published page, as main The publish job opened the published page in a fresh Chromium and its live checks passed (PG-01, PD-01, PD-02): https://github.com/afflom/me/actions/runs/43816464783 |
Guests no longer share a file
Every new guest appended to
app/specs/guests/spec.json,app/specs/guests/lock.jsonandgenerators/guests/steps.json. The open guest pull requests (#159 to #162) each conflicted with the others there.app/specs/guests/<facet>/<id>.json, with its lock beside it as<id>.lock.json.<facet>is the directory undersite/that holds its wasm.spec.jsonkeeps only the registry's name, title and purpose;lock.jsonis gone.generators/guests/steps/<facet>.json, and readsapp/specs/guests/<facet>/*.json.tools/generators/run.shreads a program'ssteps/*.jsonin name order, beside or instead of itssteps.json. A program's pin does not cover its steps directory, as it does not coversteps.json.tools/guests/gen.pyreads and writes the per-guest files.generators/guests,GenGuests) folds over the guest files in the request and no longer over one array. It is rebuilt and pinned, and its acceptance vectors use the new layout.site/google/guest.mjs,site/holon/guest.mjsandsite/read/guest.mjschange in order only. The pinned hashes are the same.To add a guest now: add
app/specs/guests/<facet>/<id>.json; for a new facet also addgenerators/guests/steps/<facet>.json. An open guest pull request moves its entry out ofspec.json,lock.jsonandsteps.jsoninto those files when it next merges main.The parts, standards and oracle registries have the same shape and still conflict; they are not in this change.
The train runs the browser acceptances on the merged tree
The train ran the fast gates on each pull request merged with main, but the browser acceptances ran only on each pull request alone. #145 and #161 were each green, and main then failed CO-01 and the timing budgets.
After the fast gates pass, the train now:
test/*/run.mjsand every*.test.mjsonce.It does this in a git worktree, so the train's tree stays what it merges, and in a shell of its own, because bash ignores errexit inside an
if. The test job's limit goes from 90 to 240 minutes. This adds about 15 minutes per pull request the train takes.The train says why it waits
A pull request whose required check ended without passing was skipped by the train without a word (#155:
page / gatescancelled at the old time limit, which read as green). The train now comments once for that head and names the check and how it ended.Both train changes are in the model,
app/specs/pipeline/workflows/merge-train.yml.json.Checks run
tools/guests/gen.py check: 18 current.tools/generators/run.sh --checktools/standards/gate.py --check --base origin/maintools/handwritten/gate.py --check --base origin/main: 26,369 hand-written lines, none added or grown.cargo test -p repo-conformance: all pass exceptrouter_ru_03(QR-03labeling-ms-per-100, 301 against 250). That fails on main too since Read mail headers through the LexLean grammar guest, synchronously #145 and is being fixed in another pull request; this change does not touch it.Not yet run on a runner: the new train step. I will run the train from this branch by hand once main is green, before this merges.
🤖 Generated with Claude Code
https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ