Repository navigation
Publish whenever the live page is older, not only for main's head - #103
Merged
Merged
Conversation
Since #89 a main run published only if its commit was still main's head. When merges come faster than a run, every run finds main moved on and none publishes: nothing deployed from #93 at 04:58Z through #102 at 06:25Z although five runs passed their gates. tools/pages/newer.sh instead asks whether the live page already holds this commit. The build job asks it to decide whether to publish, and the publish job, one at a time, asks again before it deploys, so an older run never replaces a newer page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ
Contributor
|
Live: this change is on the published page, as main The publish job opened the published page in a fresh Chromium and its live checks passed (PG-01, PD-01, PD-02): https://github.com/afflom/me/actions/runs/43687588120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #89, a main run published only if its commit was still main's head. When merges arrive faster than a run finishes, every run finds main has moved on and none of them publishes. Five main runs passed their gates between #93 (live since 04:58Z) and #102 (06:25Z), and none of them published.
tools/pages/newer.shasks a different question: does the live page (the latest successful github-pages deployment) already hold this commit? The build job uses the answer to decide whether to publish. The publish job, which runs one at a time inpages-publish, asks again just before it deploys, so an older run never replaces a newer page. I checked it against the real repo: main's head and an older commit both givego=true, and a commit the live page already holds givesgo=false.Generated by Claude Code