Add reliable CJK bookmark search#179
Open
willzhqiang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
微信 RSScan match text with punctuation between termsWhy
The current FTS5 tokenizer is
porter unicode61, which works well for English terms but is unreliable for CJK substring search. Queries such as提示词or严厉的老师can exist in bookmark text but return no results.Tests
npm run buildnpm test -- tests/bookmarks-db.test.ts(570 passing)Local smoke
node dist/cli.js search '提示词' --limit 5node dist/cli.js search '严厉的老师' --limit 3node dist/cli.js search '微信 RSS' --limit 3node dist/cli.js search 'learning' --limit 3