Draft
Conversation
…gistry-ownership-ports # Conflicts: # docs/README.md
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## dev #452 +/- ##
==========================================
- Coverage 70.59% 70.59% -0.01%
==========================================
Files 1208 1208
Lines 86806 87013 +207
Branches 11369 11383 +14
==========================================
+ Hits 61284 61424 +140
- Misses 21093 21146 +53
- Partials 4429 4443 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
补充说明一下这轮 review 的处理边界:
同时补了 NyxID create conversation 的回滚逻辑:当注册没有达到 admission-visible 时,会 unregister registry entry 并 destroy actor,避免返回成功但留下半成品 actor/ownership 状态。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the legacy
IGAgentActorStoresurface into explicit GAgent registry command, query, and command-admission ports for issue #348.What Changed
IGAgentActorRegistryCommandPort,IGAgentActorRegistryQueryPort, andIScopeResourceAdmissionPortcontracts.ActorBackedGAgentRegistryPortsbacked byGAgentRegistryGAgent.GAgentRegistryOperationenum.StateVersion,UpdatedAt, andObservedAtfreshness fields.POST /{scopeId}/gagent-actorsregistration with a 405 response so target creation stays in capability command endpoints.docs/canon/gagent-registry-ownership.mdand updates related lifecycle docs.IGAgentActorStore/ActorBackedGAgentActorStoreabstractions.Impact
This separates registry lifecycle writes, list queries, and command-path admission into distinct semantics. Command admission no longer depends on projection freshness, while list responses remain explicitly eventually consistent.
Validation
Passed:
git diff --checkbash tools/ci/test_stability_guards.shdotnet test test/Aevatar.GAgentService.Tests/Aevatar.GAgentService.Tests.csproj --no-restore --nologo --filter "FullyQualifiedName~GAgentDraftRunActorPreparationServiceTests"dotnet test test/Aevatar.AI.Tests/Aevatar.AI.Tests.csproj --no-restore --nologo --filter "FullyQualifiedName~StreamingProxyEndpointsCoverageTests"dotnet test test/Aevatar.GAgentService.Integration.Tests/Aevatar.GAgentService.Integration.Tests.csproj --no-restore --nologo --filter "FullyQualifiedName~ScopeGAgentEndpointsTests"Known existing blocker observed while reviewing:
bash tools/ci/architecture_guards.shreachesplayground_asset_drift_guardand fails becausedemos/Aevatar.Demos.Workflow.Web/wwwroot/app.jsdiffers from a freshly built CLI playground asset. This appears unrelated to the registry ownership change but still blocks the full guard command until asset drift is reconciled.