Route Create Team to Studio member creation#426
Merged
potter-sun merged 7 commits intodevfrom Apr 27, 2026
Merged
Conversation
…team-copy-flow-framing # Conflicts: # apps/aevatar-console-web/src/pages/studio/index.tsx # apps/aevatar-console-web/src/pages/teams/home.tsx # apps/aevatar-console-web/src/shared/studio/navigation.ts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dev #426 +/- ##
=======================================
Coverage 70.50% 70.50%
=======================================
Files 1198 1198
Lines 86188 86188
Branches 11297 11297
=======================================
+ Hits 60764 60766 +2
+ Misses 21037 21036 -1
+ Partials 4387 4386 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
AbigailDeng
reviewed
Apr 27, 2026
Contributor
AbigailDeng
left a comment
There was a problem hiding this comment.
Two actionable issues stood out in this flow: scope should be preserved when entering create-member from Teams, and the menu-collapse behavior likely needs a controlled state instead of relying on defaultCollapsed. Leaving both inline for easier follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create-memberintent./teams/newas a hidden legacy recovery page and update copy/tests to describe initial member draft recovery.Why
The previous Create Team page implied a persisted Team was being created, while the current product flow actually starts team construction by creating the first Studio member. This makes the route and copy honest without introducing backend team semantics.
Closes #319
Validation
npm --prefix apps/aevatar-console-web test -- --runInBand apps/aevatar-console-web/src/pages/teams/new.test.tsx apps/aevatar-console-web/src/pages/teams/home.test.tsx apps/aevatar-console-web/src/pages/studio/index.test.tsx apps/aevatar-console-web/src/app.layout.test.ts apps/aevatar-console-web/src/shared/studio/navigation.test.ts apps/aevatar-console-web/src/routesConfig.test.ts apps/aevatar-console-web/src/shared/navigation/navigationMenuSelection.test.tsnpm --prefix apps/aevatar-console-web run tscbash tools/ci/test_stability_guards.shgit diff --checkNote
npm --prefix apps/aevatar-console-web run biome:lintstill reports existing unrelated lint debt in the console web package.