Skip to content

test(offline-health): recorder outlives its factory. Principle VIII. #6161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
on8st wants to merge 1 commit into from
Closed

test(offline-health): recorder outlives its factory. Principle VIII. #6161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/offline_health_registry_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,11 @@ int main(int argc, char** argv)
{
QCoreApplication app(argc, argv);

// Declared at main scope because the `hl2` factory section 5 installs
// captures it by reference and stays installed until the process exits:
// every later rebuild of `hl2` writes through it.
RecorderState rec;

// ---- 1. the declaration exists at all ----
check(OfflineHealthRegistry::declaredFor(QStringLiteral("hl2")),
"hl2 declared an offline health source (registrar was linked in)");
Expand Down Expand Up @@ -194,7 +199,6 @@ int main(int argc, char** argv)
// resolves. OfflineHealthRegistry::declare() warns on a re-declaration --
// that warning is this line, and it is expected output.
{
RecorderState rec;
OfflineHealthRegistry::declare(
QStringLiteral("hl2"), [&rec](QObject*) {
return std::unique_ptr<IOfflineHealthSource>(
Expand Down
Loading