Repository navigation
DVK panel on the AetherSDR style guide, in the title bar's vocabulary #6249
Description
Summary
Move the Digital Voice Keyer panel (src/gui/DvkPanel.cpp) onto the AetherSDR style guide (RFC #6226). It should use the same vocabulary as the unified title bar (#6198). This covers the controls, structure and states as well as colour. Requested by the maintainer as a theming pass on the whole panel.
Today
- Hard-coded colours. The panel has 11 of them (
#1a2a3a,#00b4d8,#c8d8e8,#6a8090,#505060,#0f1520,#203040,#1a2a4a,#cc3333,#33aa33,#3388cc). It also uses pre-canon tokens. - Boxes inside boxes. Each row's
QFrame { … }rule also matches its QLabels, because QLabel is a QFrame subclass. So every name and length label is drawn as a bordered box inside the row box. - Red and green checked states. REC turns red and PLAY turns green when checked. The canon reserves red for transmit indicators, and the one control that keys the radio (PLAY) should read like MOX.
- Buttons that can't act stay enabled. STOP is enabled while idle, and PLAY and PREV are enabled on an empty slot.
Direction
- Surfaces: a
canon.raisedpanel. Slot rows becomecanon.nestedcards with acanon.linehairline and an 8 px radius. The selected row uses the title bar's active-tab pair (titlebar.tab.active.*). - Header: modelled on a title-bar radio tab. The title in ink, with a status line underneath led by a status dot.
- Controls: F-keys and transport buttons use the canon secondary-control recipe with 4 px corners, at 22 / 24 px heights. Hover is aqua and the focus ring is aqua.
- States:
- PLAY and the slot on the air use the MOX family (
tx.mox.*,background.tx). - Recording and preview use the canon cyan active treatment.
- Refusals show in
accent.danger, always with the word "failed".
- PLAY and the slot on the air use the MOX family (
- Menu: the slot menu uses the title bar's rounded menu.
PLAY being amber and REC/PREV cyan is provisional; the maintainer will adjust after review.
Activity
aethersdr-agent commentedon Oct 7, 2026
Triage:
maintainer-review+GUIChecked every claim against
src/gui/DvkPanel.cpp(598 lines, one file), the style guide, and the theme JSON. The issue is accurate; below are three corrections, then the things the fix has to handle that the Direction section doesn't name.Tokens first: every token the Direction names resolves in both
default-dark.jsonanddefault-light.json—canon.raised/nested/line/control/ink/inkSoft/muted/cyan/aqua/onAccent,titlebar.tab.active.background,titlebar.tab.active.border,titlebar.tab.hover,tx.mox.border,tx.mox.text,background.tx,accent.danger. No need to re-check. One gap: there is notitlebar.tab.active.text— the active-tab pair is fill + border only, so the selected row's text has to becanon.ink(that is whatRadioTabBar.cpp:325-326does too).Corrections to "Today"
#253545(the hover fill, L22 and L34) and#000/#fff(text-on-accent, L23/L35/L141/L151/L157). All 14 are counted bytools/audit_colours.py, whichstatic-checks.yml:425runs as--compare-src <merge-base> --strict, so the ratchet is a strict set/count comparison against the PR base — this PR lands net-negative, which is the easy part.QFrame { … }is a type selector, so it matches QFrame and its subclasses descending from the widget it is set on — QLabel is a QFrame subclass, so bothnameLabelanddurLabelpick up the row'sbackgroundand1px solidborder. The per-labelQLabel { color: … }rules (L79/L83) set no border, so they do not cancel it. Fix is one exact-class or object-name selector (.QFrame { … }/QFrame#dvkSlotRow { … }), not border overrides on every label.setEnabledcall anywhere in the file. Note the knock-on: theblockSignals/setChecked(false)/blockSignalsdance at L190 and L198 exists only because PLAY/PREV are clickable on an empty slot, and it refuses silently — no word, no message. Real enablement deletes both branches.What the Direction doesn't cover (the substance of the work)
Row theming is already dead for live-reload. L61 registers the row template through
ThemeManager::applyStyleSheet(tracked, re-resolved onthemeChanged—ThemeManager.cpp:354), butselectSlot()at L280-282 immediately overwrites all twelve with rawsetStyleSheetliterals, and the ctor callsselectSlot(1)at L267. Same for the F-key active/idle swap at L310-313. So today a theme switch leaves every row and F-key stale. A straight token substitution into those raw strings would reproduce the bug. Proposed shape: one tracked template per widget class carrying[slotState="selected"]/[slotState="onAir"]/[fkeyState="active"]property selectors, and change state withsetProperty+style()->unpolish/polish— house idiom, e.g.RadioTabBar.cpp:593,RxApplet.cpp:2031,TitleBar.cpp:132-133. That also removes twelve full-subtree restyles per click.State precedence. The selected row and the on-air row can be the same row. On-air (
background.tx/tx.mox.*) must win overtitlebar.tab.active.*; a property-selector design needs that ordering decided rather than emergent. Also, perdocs/a11y.mdand the canon's "state is never colour alone", the selected row and the on-air row each need a non-colour marker — the status line's word covers the transport state, but row selection is colour-only today and would stay colour-only under the Direction as written.The status line has five writers.
onStatusChanged(L367-369),onElapsedTick(L401-411), thecommandFailedlambda (L216), and — the one that will break a dot-plus-text design —DvkWavTransfer::statusChangedwired directly toQLabel::setTextat L470-471, plusfinishedat L473-475. A status line with a dot and anaccent.dangerstate needs a singlesetStatus(text, State)seam and that direct connect replaced. Keep the #3377 ordering documented at L206-218: re-drive from status first, set the failure text/colour after, or it gets clobbered.Enablement must fail open on
Unknown.DvkModel::Statusis{Unknown, Disabled, Idle, Recording, Preview, Playback}andUnknownis the initial value (DvkModel.h:66) — a radio that has not sent a dvk status yet sits there, andonStatusChanged'sdefault:currently prints "Status: Idle" for it. If the matrix only admitsIdle, the panel is dead on arrival on firmware that never sends one. TreatUnknownas operable, matching the existing precedent inDvkAvailabilityGate.h("fails OPEN while the entitlement is unknown", #4210).Disabledshould disable all four transport buttons, which the Direction's bullet doesn't say.Suggested matrix (maintainer to confirm):
durationMs > 0, status ∈ {Unknown, Idle} or its own statedurationMs > 0, or slot n is the active playbackRecompute from
selectSlot,onStatusChangedandonRecordingChanged(per-slotrecordingChangedfires for every id on bulk load,DvkModel.cpp:163, sorecordingsLoadedis not separately required).No disabled recipe exists in the canon.
docs/style/aethersdr-style-guide.md's secondary-control row gives fill / border / text / hover only. Suggestcanon.mutedtext overcanon.controlwith acanon.lineborder — flagging it as a maintainer call rather than inventing it.The rounded menu is not just a stylesheet.
TitleBar.cpp:136-152(roundMenuTree) setsWA_TranslucentBackground+NoDropShadowWindowHintbefore the native window exists, andsyncMenuCheckColumnpads the check column; the stylesheet at L1153-1159 is only half of it. Both live in TitleBar.cpp's anonymous namespace. Copying them intoshowContextMenu(L478-535) is the wrong move — extract a sharedroundedMenu(QMenu*)helper (e.g.src/gui/RoundedMenu.{h,cpp}) and have TitleBar use it too. The DVK menu is a fresh stackQMenuper invocation, so the before-first-show requirement is satisfied for free. While there: that menu'sQMenu::item:disabledrule (L531) is a#505060literal.Geometry / radius deviations, for the record. The guide's card recipe is 12 px radius; the issue asks for 8 px. "The canon does not change control geometry" and the standard control height is 22 px; the issue asks for 22 and 24 px. Both are the maintainer's call, just noting they are departures from the written guide, not applications of it.
Proposed change set (one PR)
src/gui/DvkPanel.cpp— the four hard-coded style constants (L19-35) and the eight inline stylesheets move toThemeManager::applyStyleSheettemplates on canon tokens; the rawsetStyleSheetcalls inselectSlot/onStatusChanged/onRecordingChangedbecome property + repolish; progress-bar chunk colours becomebackground.tx(playback) andcanon.cyan(record/preview); singlesetStatus()seam; enablement wired in.src/gui/DvkTransportState.h— the enablement matrix as a pure function, modelled onDvkAvailabilityGate.h, with atests/dvk_transport_state_test.cpp. There is no DvkPanel GUI test today (the threedvk_*tests cover the gate and WAV transfer), and this matrix is the only part that can silently regress.TitleBar.cpprepointed at it.Not blockers, but noted
default-light.jsonkeepstx.mox.textat#f0c890— the dark value — against abackground.txof#ffeacc. The MOX family is unreadable in light mode. Pre-existing and app-wide (the MOX button has it today);theme_manager_testdoes not pair-check these. Out of scope here, worth its own issue.beginTxActivity/TxCoordinator— a pre-existing TX-gate gap, unrelated to theming. Separate issue.Nothing to ask the reporter; the Direction is specific enough to implement. Holding for
aetherclaude-eligible, plus rulings on: the 8 px / 24 px departures, the disabled recipe, selected-vs-on-air precedence, and whether extracting the rounded-menu helper from TitleBar is in scope for this PR.🤖 aethersdr-agent · cost: $3.6834 · model: claude-opus-5
📍 Citation health check (Foundry Constitution Principle I): 0 resolved, 9 unresolved against
/Users/aetherclaude/workspace/AetherSDRat origin/main.Unresolved citations (9)
DvkModel.cpp:163DvkModel.h:66RadioTabBar.cpp:325-326RadioTabBar.cpp:593RxApplet.cpp:2031ThemeManager.cpp:354TitleBar.cpp:132-133TitleBar.cpp:136-152static-checks.yml:425feat(gui): the DVK panel on the AetherSDR style guide, in the title b…
feat(gui): the DVK panel on the AetherSDR style guide, in the title b…
feat(gui): the DVK panel on the AetherSDR style guide, in the title b…