Update AtkUldManager #1688
Open
Update AtkUldManager #1688
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfcomp
requested changes
Jan 4, 2026
Collaborator
wolfcomp
left a comment
wolfcomp
left a comment
There was a problem hiding this comment.
A bunch of more correct types for things.
| public partial AtkResNode* CreateAtkNode(uint type); | ||
|
|
||
| [MemberFunction("E8 ?? ?? ?? ?? F6 83 ?? ?? ?? ?? ?? 75 17")] | ||
| public partial void SetupFromULDResourceHandle(nint* resourceHandle0, nint* resourceHandle1); |
Collaborator
There was a problem hiding this comment.
Suggested change
| public partial void SetupFromULDResourceHandle(nint* resourceHandle0, nint* resourceHandle1); | |
| public partial void SetupFromULDResourceHandle(byte* uldResourceOffset0, byte* uldResoruceOffset1); |
uldResourceOffset0 has the TPHD and ASHD with loading textures.
uldResourceOffset1 has node information
| public partial void SetupFromULDResourceHandle(nint* resourceHandle0, nint* resourceHandle1); | ||
|
|
||
| [MemberFunction("40 57 41 56 41 57 48 83 EC 30 45 8B 71 18")] | ||
| public partial void SetupTimelineFromULDResourceHandle(nint* memSpace, nint* resourceHandle0, nint* resourceHandle1, ushort timelineNum); |
Collaborator
There was a problem hiding this comment.
Suggested change
| public partial void SetupTimelineFromULDResourceHandle(nint* memSpace, nint* resourceHandle0, nint* resourceHandle1, ushort timelineNum); | |
| public partial void SetupTimelineFromULDResourceHandle(IMemorySpace* memSpace, byte* uldResourceOffset0, byte* uldResoruceOffset1, ushort timelineNum); |
Function is also inlined into SetupFromULDResourceHandle
| public partial void SetupTimelineFromULDResourceHandle(nint* memSpace, nint* resourceHandle0, nint* resourceHandle1, ushort timelineNum); | ||
|
|
||
| [MemberFunction("E8 ?? ?? ?? ?? 49 8B 86 ?? ?? ?? ?? 48 85 C0 74 21")] | ||
| public partial void SetupComponentFromULDResourceHandle(nint* resourceHandle, uint componentId, ushort* timeline, AtkUldAsset* uldAsset, AtkUldPartsList* uldPartList, ushort assetNum, ushort partsNum, AtkResourceRendererManager* renderManager, bool a, bool b); |
Collaborator
There was a problem hiding this comment.
Suggested change
| public partial void SetupComponentFromULDResourceHandle(nint* resourceHandle, uint componentId, ushort* timeline, AtkUldAsset* uldAsset, AtkUldPartsList* uldPartList, ushort assetNum, ushort partsNum, AtkResourceRendererManager* renderManager, bool a, bool b); | |
| public partial void SetupComponentFromULDResourceHandle(byte* uldResourceOffset, uint componentId, ushort* timeline, AtkUldAsset* uldAsset, AtkUldPartsList* uldPartList, ushort assetNum, ushort partsNum, AtkResourceRendererManager* renderManager, bool unkResourceBool, bool keepHandle); |
uldResourceOffset comes from SetupFromULDResourceHandle with its uldResourceOffset0
| public partial void SetupComponentFromULDResourceHandle(nint* resourceHandle, uint componentId, ushort* timeline, AtkUldAsset* uldAsset, AtkUldPartsList* uldPartList, ushort assetNum, ushort partsNum, AtkResourceRendererManager* renderManager, bool a, bool b); | ||
|
|
||
| [MemberFunction("48 89 6C 24 ?? 48 89 74 24 ?? 41 56 48 83 EC 30 4C 89 49")] | ||
| public partial void SetupComponentTimelineFromULDResourceHandle(nint* resourceHandle, uint componetId, AtkTimelineManager* atkTimeLineManager, AtkResNode* node); |
Collaborator
There was a problem hiding this comment.
Suggested change
| public partial void SetupComponentTimelineFromULDResourceHandle(nint* resourceHandle, uint componetId, AtkTimelineManager* atkTimeLineManager, AtkResNode* node); | |
| public partial void SetupComponentTimelineFromULDResourceHandle(byte* uldResourceOffset, uint componetId, AtkTimelineManager* atkTimeLineManager, AtkResNode* node); |
| public partial void SetupComponentTimelineFromULDResourceHandle(nint* resourceHandle, uint componetId, AtkTimelineManager* atkTimeLineManager, AtkResNode* node); | ||
|
|
||
| [MemberFunction("E8 ?? ?? ?? ?? 0F B7 47 0E")] | ||
| public partial void BindTimeline(nint* resourceHandle, AtkUldObjectInfo* objects, byte* nodeData, AtkTimelineManager* atkTimeLineManager); |
Collaborator
There was a problem hiding this comment.
Suggested change
| public partial void BindTimeline(nint* resourceHandle, AtkUldObjectInfo* objects, byte* nodeData, AtkTimelineManager* atkTimeLineManager); | |
| public partial void BindTimeline(byte* uldResourceOffset, AtkUldObjectInfo* objects, byte* nodeData, AtkTimelineManager* atkTimeLineManager); |
| public partial void SetupText(); | ||
|
|
||
| [MemberFunction("E8 ?? ?? ?? ?? 0F B6 8E ?? ?? ?? ?? 48 8B 86")] | ||
| public partial void SetupTexture(nint* memSpace,AtkResNode* node, AtkUldPartsList* parts,uint id); |
Collaborator
There was a problem hiding this comment.
Suggested change
| public partial void SetupTexture(nint* memSpace,AtkResNode* node, AtkUldPartsList* parts,uint id); | |
| public partial void SetupTexture(IMemorySpace* memSpace, AtkResNode* node, AtkUldPartsList** parts, uint id); |
| public partial int GetNodeCount(AtkResNode* node); | ||
|
|
||
| [MemberFunction("E8 ?? ?? ?? ?? E9 ?? ?? ?? ?? 66 83 F8 04")] | ||
| public partial void ReadAtkTextNodeData(AtkTextNode* node, byte* nodeData,bool unk); |
Collaborator
There was a problem hiding this comment.
Suggested change
| public partial void ReadAtkTextNodeData(AtkTextNode* node, byte* nodeData,bool unk); | |
| public static partial void ReadAtkTextNodeData(AtkTextNode* node, byte* nodeData, bool unkResourceBool); |
github-actions
bot
removed
the
requested changes
Contributor
Author
|
All feedback has been addressed, and thanks for the suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some functions used in https://github.com/Loskh/PartyHotbar/blob/ddfc426925aa5d23c780e13bd87b802593dcbf3b/Node/Component/Base.cs#L99.
It can be used to create components via ULD files.