Skip to content

[CLIENT-4344] Rename ResultRemove() to RemoveResult() to be more consistent with the rest of the language clients and for readability #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
juliannguyen4 wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

[CLIENT-4344] Rename ResultRemove() to RemoveResult() to be more consistent with the rest of the language clients and for readability #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aerospike_helpers/expressions/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,7 @@ class LoopVarHLL(LoopVar):
_op = aerospike._AS_EXP_LOOPVAR_HLL


class ResultRemove(_BaseExpr):
class RemoveResult(_BaseExpr):
"""
Indicates entry deletion for :py:class:`ModifyByPath`.
"""
Expand Down
4 changes: 2 additions & 2 deletions test/new_tests/test_path_expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from aerospike_helpers.operations import hll_operations as hll_ops
from aerospike_helpers.operations import map_operations
from aerospike_helpers.expressions.resources import ResultType
from aerospike_helpers.expressions.base import GE, Eq, LoopVarStr, LoopVarFloat, LoopVarInt, LoopVarMap, LoopVarList, ModifyByPath, SelectByPath, MapBin, LoopVarBool, LoopVarBlob, ResultRemove, LoopVarGeoJson, LoopVarNil, CmpGeo, LoopVarHLL, HLLBin
from aerospike_helpers.expressions.base import GE, Eq, LoopVarStr, LoopVarFloat, LoopVarInt, LoopVarMap, LoopVarList, ModifyByPath, SelectByPath, MapBin, LoopVarBool, LoopVarBlob, RemoveResult, LoopVarGeoJson, LoopVarNil, CmpGeo, LoopVarHLL, HLLBin
from aerospike_helpers.expressions.map import MapGetByKey, MapPut
from aerospike_helpers.expressions.list import ListSize
from aerospike_helpers.expressions.arithmetic import Sub
Expand Down Expand Up @@ -567,7 +567,7 @@ def test_expr_result_remove(self):
cdt_ctx.cdt_ctx_all_children(),
cdt_ctx.cdt_ctx_all_children()
],
expr=ResultRemove().compile(),
expr=RemoveResult().compile(),
flags=aerospike.EXP_PATH_MODIFY_DEFAULT
)
]
Expand Down
Loading