Skip to content

unit_tests: remove AddressFromURL test #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stoffu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

unit_tests: remove AddressFromURL test #278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e952068
unit_tests: remove AddressFromURL.Success test (with URL=donate.aeon.…
stoffu Dec 20, 2022
17568c0
unit_tests.AddressFromURL.Failure: fixed seemingly wrong assertion
stoffu Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/unit_tests/address_from_url.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ TEST(AddressFromTXT, Failure)
ASSERT_STREQ("", res.c_str());
}

#if 0
TEST(AddressFromURL, Success)
{
const std::string addr = AEON_DONATION_ADDR;
Expand All @@ -104,6 +105,7 @@ TEST(AddressFromURL, Success)
EXPECT_STREQ(addr.c_str(), addresses[0].c_str());
}
}
#endif

TEST(AddressFromURL, Failure)
{
Expand All @@ -112,7 +114,7 @@ TEST(AddressFromURL, Failure)
std::vector<std::string> addresses = tools::dns_utils::addresses_from_url("example.veryinvalid", dnssec_result);

// for a non-existing domain such as "example.invalid", the non-existence is proved with NSEC records
ASSERT_TRUE(dnssec_result);
ASSERT_FALSE(dnssec_result);

ASSERT_EQ(0, addresses.size());
}