Skip to content

Remove sql injection #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4el0ve4ek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove sql injection #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions server/data_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,69 +19,69 @@ class DataController: # Tested OK

@staticmethod
def user_exists(username):
DataController.__cursor.execute(f'SELECT username FROM customer WHERE username = \'{username}\';')
DataController.__cursor.execute('SELECT username FROM customer WHERE username = ?;', username)
return DataController.__cursor.fetchone() is not None

@staticmethod
def add_user(username, customer_info, pwd_hash):
DataController.delete_user(username)
DataController.__cursor.execute(f'INSERT INTO customer (username, customer_info, pwd_hash)'
f'VALUES (\'{username}\', \'{customer_info}\', \'{pwd_hash}\');COMMIT;')
DataController.__cursor.execute('INSERT INTO customer (username, customer_info, pwd_hash)'
'VALUES (?, ?, ?);COMMIT;', username, customer_info, pwd_hash)

@staticmethod
def delete_user(username):
DataController.__cursor.execute(f'DELETE FROM customer WHERE username = \'{username}\';COMMIT;')
DataController.__cursor.execute('DELETE FROM customer WHERE username = ?;COMMIT;', username)
DataController.delete_token(username)

@staticmethod
def get_customer_info(username):
DataController.__cursor.execute(f'SELECT customer_info FROM customer WHERE username = \'{username}\';')
DataController.__cursor.execute('SELECT customer_info FROM customer WHERE username = ?;', username)
data = DataController.__cursor.fetchone()
return None if data is None else json.loads(data.customer_info)

@staticmethod
def update_customer_info(username, new_customer_info):
DataController.__cursor.execute(f'UPDATE customer SET customer_info = \'{json.dumps(new_customer_info)}\''
f'WHERE username = \'{username}\';COMMIT;')
DataController.__cursor.execute('UPDATE customer SET customer_info = ?'
'WHERE username = ?; COMMIT;', json.dumps(new_customer_info), username)

@staticmethod
def token_exists(token):
DataController.__cursor.execute(f'SELECT token FROM auth_token WHERE token = \'{token}\';')
DataController.__cursor.execute(f'SELECT token FROM auth_token WHERE token = ?', token)
return DataController.__cursor.fetchone() is not None

@staticmethod
def add_token(username, token, relevance_period=TOKEN_RELEVANCE_PERIOD):
DataController.delete_token(username)
DataController.__cursor.execute(f'INSERT INTO auth_token (username, token, relevance_limit)'
f'VALUES (\'{username}\', \'{token}\', \'{round(time()) + relevance_period}\');'
f'COMMIT;')
DataController.__cursor.execute('INSERT INTO auth_token (username, token, relevance_limit)'
'VALUES (?, ?, ?);'
'COMMIT;', username, token, round(time()) + relevance_period)

@staticmethod
def delete_token(username):
DataController.__cursor.execute(f'DELETE FROM auth_token WHERE username = \'{username}\';COMMIT;')
DataController.__cursor.execute('DELETE FROM auth_token WHERE username = ?; COMMIT;', username)

@staticmethod
def get_token(username):
DataController.__cursor.execute(f'SELECT token FROM auth_token WHERE username = \'{username}\';')
DataController.__cursor.execute('SELECT token FROM auth_token WHERE username = ?;', username)
data = DataController.__cursor.fetchone()
return None if data is None else data.token

@staticmethod
def check_token_relevance(token):
DataController.__cursor.execute(f'SELECT relevance_limit FROM auth_token WHERE token = \'{token}\';')
DataController.__cursor.execute('SELECT relevance_limit FROM auth_token WHERE token = ?;', token)
data = DataController.__cursor.fetchone()
return data is not None and time() < data.relevance_limit

@staticmethod
def get_username_by_token(token):
DataController.__cursor.execute(f'SELECT username FROM auth_token WHERE token = \'{token}\';')
DataController.__cursor.execute('SELECT username FROM auth_token WHERE token = ?;', token)
data = DataController.__cursor.fetchone()
return None if data is None else data.username

@staticmethod
def verify_auth_by_pwd_hash(username, pwd_hash):
DataController.__cursor.execute(
f'SELECT username FROM customer WHERE username = \'{username}\' and pwd_hash = \'{pwd_hash}\';')
'SELECT username FROM customer WHERE username = ? and pwd_hash = ?;', username, pwd_hash)
return DataController.__cursor.fetchone() is not None

@staticmethod
Expand Down