Gate 4: staged Read-Need Fit settlement#9
Conversation
|
Deployment failed with the following error: |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
https://github.com/engineeredsoftware/ENGI/blob/141b1ee00224f9aec9476128af335bb732444507/packages/pipeline-hosts/src/asset-pack-harness.ts#L1546-L1548
Reject missing accepted Read-Need before harness execution
When the manifest does not contain an already accepted readNeed (or contains one still in review), this fallback synthesizes and accepts a new Need inside the live harness, so a direct /api/pipeline-harness/asset-pack request with requireAcceptedReadNeed defaulting to true can still run candidate recall without the review/acceptance boundary the gate is adding. This bypasses the newly documented invariant that only a user-accepted Read-Need is admissible for Need-Fit search; the harness should fail closed here instead of manufacturing acceptance.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Validation
pnpm --filter @bitcode/pipeline-asset-pack exec jest --config jest.config.cjs --runTestsByPath src/__tests__/read-need.test.ts --runInBandpnpm --filter @bitcode/pipeline-hosts exec jest --config jest.config.cjs --runTestsByPath src/__tests__/asset-pack-harness.test.ts --runInBandpnpm --dir uapi exec jest --runTestsByPath tests/api/readReviewRoute.test.ts tests/api/pipelineHarnessRoute.test.ts tests/terminalPipelineHarnessClient.test.ts tests/terminalDepositReadWorkbench.test.ts tests/pipelineExecutionLogHeader.test.tsx --runInBandpnpm --filter @bitcode/pipeline-asset-pack typecheckpnpm --filter @bitcode/pipeline-hosts typecheckpnpm --dir uapi exec tsc --noEmit --pretty false --incremental falsepnpm --filter @bitcode/pipeline-asset-pack exec jest --config jest.config.cjs --passWithNoTests --forceExitpnpm --filter @bitcode/pipeline-hosts exec jest --config jest.config.cjs --passWithNoTests --forceExitnpm --prefix protocol-demonstration run test:v28-mvp-qahttp://127.0.0.1:3028/terminalconfirmed the staged Reading section, Read-Need actions, Need-Fit action, source-safe preview panel, no Next error overlay, and HTTP 200.git diff --checkNotes