V33 Gate 4: Harden ChatGPT App Action Contracts#69
Conversation
Add package-owned ChatGPT App Reading action contracts covering Read, Need, Finding Fits, preview, fee, settlement, and delivery actions with source-safe renderers, proof roots, denied-state repair posture, generated artifact checks, workflow wiring, and ChatGPT App registry integration. Validate with V33 Gate 1-4 checkers, V33 strict spec quality, BTD typecheck/full Jest, ChatGPT App typecheck/full Jest, protocol tests, canon posture/canonical-input checks, V32 promotion readiness, and diff/secret hygiene.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a385aaac1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| writeAdmission: contract.actionId === 'bitcode_settle_asset_pack' || contract.actionId === 'bitcode_deliver_asset_pack' | ||
| ? 'chatgpt-confirmed-action' | ||
| : 'not-required-for-source-safe-chatgpt-action', |
There was a problem hiding this comment.
The new ChatGPT Reading action executor always emits an accepted response and marks writeAdmission as chatgpt-confirmed-action for bitcode_settle_asset_pack/bitcode_deliver_asset_pack, but there is no check that confirmed is actually true. Because the generated validator only requires a boolean, calls with confirmed: false still pass and get an admitted response instead of a CONFIRMATION_REQUIRED denial, which breaks the explicit-confirmation gate these contracts declare.
Useful? React with 👍 / 👎.
1 participant
Summary
ChatGptAppActionContractprimitives for Read, Need review, Finding Fits, AssetPack preview, BTC fee quote, settlement, and delivery actions.bitcode/v33-chatgpt-app-action-contracts.json, update V33 specs/roadmap/parity, and wire Gate Quality to run Gate 4 checks/testsValidation
pnpm run check:v33-gate1pnpm run check:v33-gate2pnpm run check:v33-gate3pnpm run check:v33-gate4node scripts/check-bitcode-spec-family.mjs --version V33 --mode draft --current-target V32node scripts/check-bitcode-canonical-inputs.mjs --current-target V32node scripts/check-bitcode-canon-posture-drift.mjs --active-canon V32 --draft-target V33node scripts/check-v32-gate10-promotion-readiness.mjs --promotion-mode --skip-branch-checknode scripts/run-bitcode-spec-quality.mjs --mode strict-version --version V33pnpm --filter @bitcode/btd typecheckpnpm --filter @bitcode/btd testpnpm --dir packages/chatgptapp exec tsc --noEmit --pretty falsepnpm --dir packages/chatgptapp exec jest --runInBandpnpm --filter @bitcode/protocol testgit diff --cached --check