V31 Gate 5: Wallet And BTD Pane Readiness#48
Conversation
Introduce the BTD-owned Wallet/BTD support projection for no-custody signer posture, network readiness, source-safe read-right summaries, account treasury boundaries, and settlement blockers. Wire the projection through the Auxillaries API contract, user data hook, and Wallet pane so Terminal users can inspect BTD support without exposing protected source or Exchange market assumptions. Refresh V31 specs, roadmap, docs, gate workflow coverage, and targeted BTD/API/UI tests for the Gate 5 closure criteria.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fcaafced9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const settlementBlockers = [ | ||
| signerReady ? null : `wallet.${signerRequiredAction}`, | ||
| networkReadiness.state === 'blocked' ? networkReadiness.blocker : null, | ||
| ].filter((entry): entry is string => Boolean(entry)); |
There was a problem hiding this comment.
Block settlement when wallet network is unverified
Update settlement blocker derivation to treat degraded network readiness as blocking for settlement: when a wallet is verified but network is missing, deriveNetworkReadiness sets state: 'degraded' with blocker wallet.network_unverified, but this code only includes network blockers when state is 'blocked', so settlementReadiness incorrectly resolves to ready with no blockers. This can surface false-positive settlement readiness and allow downstream flows to proceed without required network verification.
Useful? React with 👍 / 👎.
Summary
Validations