V30 Gate 5: Testnet Ledger Projection Hardening#37
Conversation
Adds package-owned object-storage artifact facts and secret-free Supabase staging-testnet readback receipts to BTD reconciliation reports. Wires the report through the AssetPack Sandbox harness and Terminal journal reconciliation UI so ledger, database, object-storage, and private facts remain distinct with deterministic repair roots. Covers drift, quarantine, retry, protected-source rejection, staging readback blocking, API serialization, harness generation, Terminal rendering, V30 spec parity, and the Gate 5 workflow checker.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0fd62f262
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const repairSnapshots = mergeRepairSnapshots( | ||
| journal?.repairs || [], | ||
| buildReportRepairSnapshots(settlement), | ||
| ); |
There was a problem hiding this comment.
Derive reconciliation state from merged repair snapshots
repairSnapshots now merges report repairs with journal repairs, but deriveState still classifies repairable using only journal?.repairs.length. In runs where the new ledger-database report contributes non-blocking repairs (for example a finality mismatch that does not set blocking), the snapshot can be labeled aligned even though repair receipts/actions are present. This under-reports drift and can lead operators to treat an unresolved reconciliation as healthy.
Useful? React with 👍 / 👎.
Allow Terminal reconciliation cards to render historical or partial journal snapshots that predate object-storage fact projection while preserving the new object-storage section for current reports. Proof: pnpm --dir uapi exec jest --runTestsByPath tests/api/readReviewRoute.test.ts tests/api/pipelineHarnessRoute.test.ts tests/terminalPipelineHarnessClient.test.ts tests/terminalDepositReadWorkbench.test.ts tests/terminalTransactionQuery.test.ts tests/terminalTransactionReadModel.test.ts tests/terminalWalletBtcOperation.test.ts tests/terminalJournalReconciliation.test.ts tests/terminalOrganizationAuthority.test.ts tests/protocolCommercialBoundary.test.ts tests/terminalTransactionDetailCards.test.tsx tests/terminalTransactionDetailSnapshot.test.ts tests/terminalUxBrowserProof.test.tsx tests/pipelineExecutionLogHeader.test.tsx --runInBand; pnpm -C uapi exec jest --coverage; pnpm --dir uapi exec tsc --noEmit --pretty false
Summary
Validation