V29 Gate 10: Local And Staging Promotion Readiness#29
Conversation
Specify and validate the V29 local/staging promotion-readiness gate, add the V29 promotion workflow, teach promotion scripts to prepare V29 canon artifacts, and align protocol package runtime posture for promotion. Proof: pnpm run check:v29-gate10; node scripts/check-v29-gate10-local-staging-promotion-readiness.mjs --promotion-mode --skip-branch-check; node scripts/run-bitcode-spec-quality.mjs --mode basic; npm run promote:canon -- --version V29 --commit HEAD --dry-run; npm --prefix protocol-demonstration test -- --test-name-pattern 'runtime promotion preparation rewrites optional protocol package posture carriers|runtime promotion preparation rewrites canon posture source and README'; git diff --check; YAML parse for Gate/Canon/V29 promotion workflows.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8117244002
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| packageCanonPosture.includes("ACTIVE_CANON_VERSION = 'V28'") && | ||
| packageCanonPosture.includes("DRAFT_TARGET_VERSION = 'V29'") && | ||
| packageState.includes('"activeCanonVersion": "V28"') && | ||
| packageState.includes('"draftTargetVersion": "V29"') && | ||
| packageState.includes('"activeProvenAppendixPath": "BITCODE_SPEC_V28_PROVEN.md"') && | ||
| packageState.includes('"draftSpecPath": "BITCODE_SPEC_V29.md"'), |
There was a problem hiding this comment.
When BITCODE_SPEC.txt has already been promoted to V29, both gate/promotion workflows call this checker in --promotion-mode (see the V29 branches in .github/workflows/bitcode-gate-quality.yml and .github/workflows/v29-canon-promotion.yml), but this assertion still hard-requires packages/protocol posture values to remain V28 active / V29 draft. After promotion automation rewrites these files to V29/V30, the check will fail and block post-promotion CI on the version branch. The checker should branch its expected posture by pointer/promotion state rather than always enforcing pre-promotion values.
Useful? React with 👍 / 👎.
1 participant
Summary
Proof