V47 Gate 4: Depositor Website Completion#236
Conversation
Record Gate 4 depositor website completion law across BITCODE_SPEC_V47, DELTA, NOTES, PARITY, and the roadmap; advance roadmap posture to working Gate 4 with Gate 3 recorded as latest closed; and render the BTC source-to-shares preview as its own source-safe measurement-review cell on /deposit with depositor/treasury share basis points and proof state. Generate .bitcode/v47-depositor-website-completion.json and refresh the Gate 2/3 artifacts against the advanced spec family. Add roadmapWorkingGatePostureAtLeast to version-posture so closed-gate roadmap predicates stay green as working-gate posture advances; repair the Gate 2 predicate with it and future-proof Gates 3 and 4. Validated with: - pnpm --filter @bitcode/protocol test - pnpm --dir uapi exec jest tests/depositRouteModel.test.ts tests/depositPageClient.test.tsx - node scripts/check-v47-gate1-scope-measurement-launch-freeze.mjs --skip-branch-check - pnpm run check:v47-gate2 && pnpm run check:v47-gate3 && pnpm run check:v47-gate4 - node scripts/check-bitcode-spec-family.mjs --version V46 --mode promoted --current-target V46 - node scripts/check-bitcode-spec-family.mjs --version V47 --mode draft --current-target V46 - node scripts/check-bitcode-canonical-inputs.mjs --current-target V46 - node scripts/check-bitcode-canon-posture-drift.mjs --active-canon V46 --draft-target V47 - node scripts/run-bitcode-spec-quality.mjs --mode basic - node scripts/check-import-casing.mjs - uapi eslint and tsc --noEmit on the deposit client - git diff --check Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eac35bb109
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| try { | ||
| await handleRecordActivity({ | ||
| type: "pipeline:deposit-option-synthesis", |
There was a problem hiding this comment.
Preserve the deposit pipeline type in history rows
When this is posted to the real /api/executions/history route, postExecutionHistoryRoute normalizes body.pipeline_type through normalizeAgenticExecutionStorageType, and unknown pipeline:* values fall back to agentic-execution:asset-pack (packages/api/src/executions/agentic-execution.ts). As a result the inserted row and returned execution will not retain pipeline:deposit-option-synthesis, even though this gate adds distinct synthesis/review/admission event IDs and the new test only works because it mocks the API response. Add storage/query support for these deposit pipeline types, or avoid relying on type to carry this audit event.
Useful? React with 👍 / 👎.
Summary
Closes V47 Gate 4 (Depositor Website Completion) into
version/v47while V46 remains active canon./depositroute session (connect source → synthesize options → review options → submit deposit → read Depository state) journalspipeline:deposit-option-synthesis,pipeline:deposit-option-review, andpipeline:deposit-option-admissionas source-safe execution rows; the measurement review now renders the BTC source-to-shares preview as its own cell (depositor/treasury share basis points andsourceToSharesProofState) alongside measurements, criticality, demand, ROI, BTD potential, option roots, compensation estimates, and organization/wallet authority readback, with admitted options synchronized to/packs.BITCODE_SPEC_V47.md(status parity line, Appendix D gate ownership, Appendix E artifact contract, Gate 4 completion condition),DELTA(Gate 4 ownership paragraph),NOTES(Gate 4 simplified reading),PARITY_MATRIX(seller state machine and Seller visualization rows, artifact inventory, Gate 4 completion condition), andSPECIFICATIONS_ROADMAP.md(Gate 4 closure target/anchor, working/latest-closed posture) now record Gate 4..bitcode/v47-depositor-website-completion.jsonis generated and fresh; Gate 2/3 artifacts regenerated against the advanced spec family.roadmapWorkingGatePostureAtLeastinversion-posture.jskeeps closed-gate roadmap predicates green as the roadmap's working-gate posture advances (repairs Gate 2 now that "Latest closed gate" moved to Gate 3; future-proofs Gates 3 and 4), following the V46 rehearsal-predicate repair precedent.Validation
pnpm --filter @bitcode/protocol test(224 pass)jest tests/depositRouteModel.test.ts tests/depositPageClient.test.tsx(8 pass)check:v47-gate1(skip-branch-check),check:v47-gate2,check:v47-gate3,check:v47-gate4all passgit diff --checktsc --noEmitclean🤖 Generated with Claude Code