Skip to content

Close V28 gate 13 promotion readiness#18

Merged
geraldarthurdavis merged 1 commit into
version/v28from
v28/gate-13-product-closure-promotion-readiness
May 20, 2026
Merged

Close V28 gate 13 promotion readiness#18
geraldarthurdavis merged 1 commit into
version/v28from
v28/gate-13-product-closure-promotion-readiness

Conversation

@geraldarthurdavis

Copy link
Copy Markdown
Contributor

Summary

  • adds the Gate 13 product-closure/promotion-readiness check and wires it into gate-quality and V28 promotion workflows
  • expands the V28 promotion dry-run plan with Gate 9-13, readback, BTD, full demonstration, pipeline package, and focused UAPI checks
  • aligns the full protocol-demonstration proof suite with current proof catalog counts and active-canon V27/V28 posture
  • hardens the staging-testnet readback verifier with bounded single-client DB auditing and records Data API readback evidence for Gate 13

Validation

  • pnpm run check:v28-metadevelopment
  • pnpm run check:v28-gate9
  • pnpm run check:v28-gate10
  • pnpm run check:v28-gate11
  • pnpm run check:v28-gate12
  • pnpm run check:v28-gate13
  • pnpm test:qa:v28:pipeline-readback
  • pnpm qa:v28:pipeline-readback -- --env-file .env.local --expected-host tkpyosihuouusyaxtbau.supabase.co --readback-source rest --lookback-hours 96
  • pnpm qa:v28:pipeline-readback -- --env-file .env.local --expected-host tkpyosihuouusyaxtbau.supabase.co --readback-source db --lookback-hours 96 (expected local DB reachability timeout; verifier now fails fast)
  • pnpm --filter @bitcode/btd typecheck
  • pnpm --filter @bitcode/btd test
  • pnpm --filter @bitcode/pipeline-asset-pack typecheck
  • pnpm --filter @bitcode/pipeline-hosts typecheck
  • pnpm --filter @bitcode/pipeline-asset-pack exec jest --config jest.config.cjs --passWithNoTests --forceExit
  • pnpm --filter @bitcode/pipeline-hosts exec jest --config jest.config.cjs --passWithNoTests --forceExit
  • pnpm --dir uapi exec jest --runTestsByPath tests/api/readReviewRoute.test.ts tests/api/pipelineHarnessRoute.test.ts tests/terminalPipelineHarnessClient.test.ts tests/terminalDepositReadWorkbench.test.ts tests/pipelineExecutionLogHeader.test.tsx tests/orbitalsInterfacesPane.test.tsx --runInBand
  • npm --prefix protocol-demonstration test
  • npm --prefix protocol-demonstration run test:v28-mvp-qa
  • bash scripts/find-uppercase-raw-promptparts.sh
  • bash scripts/check-import-casing.sh
  • git diff --check
  • node scripts/check-bitcode-pre-commit.mjs
  • node scripts/promote-bitcode-canon.mjs --version V28 --commit HEAD --dry-run

Add the Gate 13 product-closure readiness check, wire it into gate and promotion workflows, and expand the V28 promotion dry-run command plan.

Align the full protocol demonstration proof suite with the current proof catalog and active-canon posture, including the deposit-to-read-fit enum and superseded V26 readiness assertions.

Harden staging-testnet readback validation with bounded DB audits, Data API evidence, updated QA/spec notes, and verifier coverage for the single-client DB path.
@vercel

vercel Bot commented May 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
engi-uapi Ready Ready Preview, Comment May 20, 2026 2:30pm

@geraldarthurdavis
geraldarthurdavis merged commit 4bb9667 into version/v28 May 20, 2026
29 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c6108fb8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

--runInBand

- name: Test pipeline readback verifier
run: pnpm test:qa:v28:pipeline-readback

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove duplicate readback verifier run in gate-quality

This step reruns pnpm test:qa:v28:pipeline-readback even though Validate draft canon posture already calls promote-bitcode-canon --dry-run, and the V28 dry-run plan now includes the same command (scripts/promote-bitcode-canon.mjs, V28 command plan). On V27 draft branches this duplicates a network-sensitive check in one workflow run, increasing CI time and flake exposure enough to block gate closures.

Useful? React with 👍 / 👎.

echo "Unexpected BITCODE_SPEC.txt pointer: $POINTER" >&2
exit 1
fi
pnpm test:qa:v28:pipeline-readback

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid duplicate readback verifier in promotion workflow

When BITCODE_SPEC.txt is V27, this job already executes node scripts/promote-bitcode-canon.mjs --version V28 --commit HEAD --dry-run, and the updated V28 dry-run plan includes pnpm test:qa:v28:pipeline-readback; running it again here duplicates the same external-readiness check in a single PR validation pass. This adds avoidable runtime and flakiness risk on the main promotion path (version/v28 -> main).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant