Gate 10: close Read-Need comprehension#15
Conversation
Adds the typed bitcode.read.request record inside Read-Needs, preserves feedback and previous-Need lineage during resynthesis, and exposes ReadNeedComprehensionSynthesis contract traces through route telemetry. Updates Terminal gating so accepted Read-Need truth is recorded with Finding Fits admission evidence, adds focused package and route coverage, and wires the Gate 10 readiness check into V28 gate quality.
|
Deployment failed with the following error: |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d28506b763
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| readNeed: action === 'resynthesize_read_need' ? readNeed : undefined, | ||
| previousReadNeed: action === 'resynthesize_read_need' ? readNeed : undefined, |
There was a problem hiding this comment.
readNeed to resynthesis callback dependencies
handleSynthesizeReadNeed now sends readNeed/previousReadNeed for resynthesize_read_need, but the callback is memoized without readNeed in its dependency list. After a user synthesizes once and immediately clicks resynthesize (without changing feedback or scenario), this closure can still hold readNeed = null, so the request drops lineage and feedback carry-forward is bypassed as if it were a fresh synthesis. Include readNeed in the useCallback dependencies (or read from functional state) so resynthesis always uses the latest Need.
Useful? React with 👍 / 👎.
Rename the second Reading pipeline and dependent contract fields to ReadFitsFindingSynthesis, including route payloads, Terminal harness types, QA text, and gate checks. Move the concrete ReadFitsFindingSynthesis PTRR agent files and runtime registry keys under prefixed names so setup, read-comprehension, and AssetPack synthesis identifiers match the V28 pipeline contract.
1 participant
Summary
bitcode.read.requesttruth in synthesized Read-Needs, including source context, closure criteria, feedback history, and previous Need lineage for resynthesisReadNeedComprehensionSynthesiscontract trace telemetry for phases, PTRR agents, PTRR steps, and ThricifiedGeneration identifiersValidation
pnpm run check:v28-gate10pnpm --filter @bitcode/pipeline-asset-pack exec jest --config jest.config.cjs --runTestsByPath src/__tests__/read-need.test.ts src/__tests__/reading-pipeline-contract.test.ts --runInBandpnpm --dir uapi exec jest --runTestsByPath tests/api/readReviewRoute.test.ts tests/terminalPipelineHarnessClient.test.ts tests/terminalDepositReadWorkbench.test.ts --runInBandpnpm --filter @bitcode/pipeline-asset-pack typecheckpnpm --dir uapi exec tsc --noEmit --pretty falsepnpm --filter @bitcode/pipeline-hosts typecheckpnpm run check:v28-metadevelopmentpnpm run check:v28-gate9 && pnpm run check:v28-gate10 && node scripts/promote-bitcode-canon.mjs --version V28 --commit HEAD --dry-runpnpm --filter @bitcode/pipeline-hosts exec jest --config jest.config.cjs --runInBandpnpm --filter @bitcode/pipeline-asset-pack exec jest --config jest.config.cjs --runInBandpnpm --dir uapi exec jest --runTestsByPath tests/api/pipelineHarnessRoute.test.ts tests/pipelineExecutionLogHeader.test.tsx tests/orbitalsInterfacesPane.test.tsx --runInBandnpm --prefix protocol-demonstration run test:v28-mvp-qanode scripts/check-bitcode-pre-commit.mjsgit diff --check/git diff --cached --check