V39 Gate 6: AssetPack Preview Quote Boundary#141
Conversation
Adds the AssetPackPreviewBoundary package primitive for source-safe preview, selected-fit provenance, deterministic share-to-fee BTC quote receipts, disclosure review, settlement instructions, withheld PR delivery posture, replay receipts, repair posture, and storage projection. Wires the boundary into AssetPack preprocess/postprocess, package/protocol exports, V39 proof artifact generation and gate checks, CI quality workflows, and V39 specification/readme/parity documentation. Validated with check:v39-gate6, focused AssetPack preview/disclosure/postprocess/read-need Jest tests, package and protocol typechecks, protocol artifact tests, uapi typecheck/build, spec-family checks, canon-posture drift checks, Gate 5 regression check, diff whitespace check, and staged secret marker scan.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab3b18d1d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (storedBoundary?.schema === 'bitcode.asset-pack.preview-boundary') { | ||
| return storedBoundary as AssetPackPreviewBoundary; |
There was a problem hiding this comment.
If a boundary was persisted earlier in preprocess (before a PR URL exists), this early return reuses it unchanged during postprocess, so assetPackPreviewBoundary.deliveryPosture.pullRequestTarget can remain null even when output.deliveryMechanism.prUrl is now available. In that common flow, downstream settlement/delivery evidence is stale and does not reflect the real pull-request target; recompute or patch the stored boundary when a newer delivery URL is present.
Useful? React with 👍 / 👎.
1 participant
Summary
AssetPackPreviewBoundaryfor source-safe AssetPack preview, selected-fit provenance, deterministic share-to-fee BTC quote receipts, disclosure review, settlement instructions, withheld pull-request delivery posture, replay receipts, repair posture, and storage projection.Validation
pnpm run check:v39-gate6pnpm --filter @bitcode/pipeline-asset-pack exec jest --config jest.config.cjs --runTestsByPath src/__tests__/asset-pack-preview-boundary.test.ts src/__tests__/asset-pack-disclosure.test.ts src/__tests__/postprocess.test.ts src/__tests__/read-need.test.ts --runInBand --forceExitpnpm --filter @bitcode/pipeline-asset-pack run typecheckpnpm --filter @bitcode/protocol run typechecknode --test --test-force-exit packages/protocol/test/v39-assetpack-preview-quote-boundary.test.jspnpm --dir uapi exec tsc --noEmit --pretty falsepnpm --dir uapi run buildnode scripts/check-bitcode-spec-family.mjs --version V39 --mode draft --current-target V38node scripts/check-bitcode-canon-posture-drift.mjs --active-canon V38 --draft-target V39node scripts/check-v39-gate5-read-fits-finding-runtime.mjs --skip-package-testsgit diff --check