V39 Gate 2: Depository Supply Indexing And Searchable Deposit Lifecycle#137
Conversation
Add the package-owned DepositorySupplyIndex, source-safe search documents, vector/storage projections, rights boundary, and repair-aware Finding Fits handoff. Generate the V39 Gate 2 proof artifact, checker, protocol tests, package tests, docs, roadmap updates, and workflow wiring for Gate 2 closure.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c121a4c41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const depositorySupplyIndex = recordValue(record.depositorySupplyIndex) || recordValue(record.depositorySupply); | ||
| if (depositorySupplyIndex) { | ||
| const assets = depositorySupplyAssetsFromIndex(depositorySupplyIndex as unknown as DepositorySupplyIndex); | ||
| if (assets.length) return assets; |
There was a problem hiding this comment.
Honor supply-index gating when no searchable records
When a depositorySupplyIndex is present but contains zero searchable records (for example, all records are blocked-readiness), this code falls through to raw depositoryAssets/depositCandidates and reintroduces candidates that the supply index explicitly gated out. In runDepositorySearchForPipelineInput, those raw collections are still passed alongside the index, so blocked supply can still be ranked and selected, bypassing the new lifecycle/rights boundary and potentially re-exposing non-source-safe content from raw units. If an index is supplied, asset selection should be derived strictly from depositorySupplyAssetsFromIndex (even if empty).
Useful? React with 👍 / 👎.
Replace the gate-quality demonstration full historical proof suite with the maintained demonstration typecheck and V28 MVP QA surface. This keeps gate PR checks deterministic while preserving promotion-grade coverage for heavier canon workflows.
bb190aa to
0d4cc62
Compare
Summary
Validation