V48 Gate 3 (implementation-only): reliable SDIVF token rollup and zero-option fail-closed

Export sumLlmTokensFromExecutionTree that walks Map and array children so deposit
synthesize-options captures nested PTRR usage. Fail closed when Validation leaves
zero admissible candidates (missing absolutes or source-safety drops).

Author: geraldarthurdavis

packages/pipelines/asset-pack/src/asset-packs-synthesis-pipeline.ts

@@ -183,12 +183,21 @@ export interface FormalSynthesisOutcome {
   totalTokens: number | null;
 }
 
-function sumLlmTokens(execution: Execution): number | null {
+/**
+ * Sum LLM usage across an Execution tree (Map children + array fallbacks).
+ * Used by formal synthesis and by the deposit synthesize-options route so
+ * nested PTRR/Failsafe generation usage is not missed.
+ */
+export function sumLlmTokensFromExecutionTree(execution: {
+  get?: (namespace: string, key: string) => unknown;
+  children?: Map<string, unknown> | unknown[] | { values?: () => IterableIterator<unknown> };
+}): number | null {
   let total = 0;
   let seen = false;
-  const walk = (node: Execution) => {
+  const walk = (node: any) => {
+    if (!node) return;
     try {
-      const usage = node.get<Record<string, number>>('llm', 'usage');
+      const usage = node.get?.('llm', 'usage') as Record<string, number> | undefined;
       if (usage && typeof usage === 'object') {
         const prompt =
           usage.promptTokens ?? usage.prompt_tokens ?? usage.inputTokens ?? usage.input_tokens ?? 0;
@@ -210,12 +219,25 @@ function sumLlmTokens(execution: Execution): number | null {
         }
       }
     } catch {}
-    for (const child of node.children.values()) walk(child);
+    const children = node.children;
+    if (!children) return;
+    if (typeof children.values === 'function') {
+      for (const child of children.values()) walk(child);
+      return;
+    }
+    if (Array.isArray(children)) {
+      for (const child of children) walk(child);
+    }
   };
   walk(execution);
   return seen ? total : null;
 }
 
+/** @deprecated alias — use sumLlmTokensFromExecutionTree */
+function sumLlmTokens(execution: Execution): number | null {
+  return sumLlmTokensFromExecutionTree(execution);
+}
+
 export async function synthesizeAssetPackCandidatesFormal(
   request: FormalSynthesisRequest,
   candidateSetSchema: z.ZodType<{ options: FormalSynthesisRawOption[] }>,

packages/pipelines/asset-pack/src/asset-packs-synthesis.ts

@@ -5,10 +5,13 @@ import type { MeasurementSpec } from '@bitcode/agent-generics';
 
 import {
   synthesizeAssetPackCandidatesFormal,
+  sumLlmTokensFromExecutionTree,
   type FormalSynthesisRawOption,
 } from './asset-packs-synthesis-pipeline';
 import { isAssetPackRealInferenceEnabled } from './runtime-inference-policy';
 
+export { sumLlmTokensFromExecutionTree };
+
 /**
  * AssetPacksSynthesis — the single Bitcode synthesis/measurement pipeline
  * (V48 architecture law, QA ledger F12).

uapi/app/api/deposit/synthesize-options/route.ts

@@ -11,6 +11,7 @@ import { createStreamingExecution, emitPhaseTransition } from '@bitcode/pipeline
 import {
   applyExclusionsToInventory,
   normalizeProtectedIpExclusions,
+  sumLlmTokensFromExecutionTree,
   validateDepositSynthesisOptions,
   type AssetPacksSynthesisResult,
   type AssetPacksSynthesisSourceInventory,
@@ -384,39 +385,8 @@ export async function POST(request: Request) {
       protectedIpExclusions,
       candidateKinds: DEPOSIT_OPTION_KINDS,
     });
-    // Roll up usage from the SDIVF execution tree when available.
-    let rolledTokens: number | null = null;
-    try {
-      let total = 0;
-      let seen = false;
-      const walk = (node: any) => {
-        if (!node) return;
-        try {
-          const usage = node.get?.('llm', 'usage');
-          if (usage && typeof usage === 'object') {
-            const prompt =
-              usage.promptTokens ?? usage.prompt_tokens ?? usage.inputTokens ?? usage.input_tokens ?? 0;
-            const completion =
-              usage.completionTokens ??
-              usage.completion_tokens ??
-              usage.outputTokens ??
-              usage.output_tokens ??
-              0;
-            const n = Number(prompt) + Number(completion);
-            if (Number.isFinite(n) && n > 0) {
-              total += n;
-              seen = true;
-            }
-          }
-        } catch {}
-        const children = node.children ?? node._children ?? [];
-        if (Array.isArray(children)) for (const child of children) walk(child);
-      };
-      walk(execution);
-      rolledTokens = seen ? total : null;
-    } catch {
-      rolledTokens = null;
-    }
+    // Roll up usage from the full SDIVF execution tree (Map children + nested PTRR).
+    const rolledTokens = sumLlmTokensFromExecutionTree(execution as never);
     const result: AssetPacksSynthesisResult = {
       lens: 'deposit',
       candidates: validated.candidates,
@@ -432,6 +402,15 @@ export async function POST(request: Request) {
     await emitStatus(
       `Validated candidates fail-closed: ${result.candidates.length} admissible, ${result.droppedCandidateCount} dropped.`,
     );
+    if (result.candidates.length === 0) {
+      const detail =
+        result.exclusionViolations.length > 0
+          ? result.exclusionViolations.slice(0, 5).join('; ')
+          : 'no admissible measured candidates survived Validation absolutes / source-safety checks';
+      throw new Error(
+        `AssetPacksSynthesis produced zero admissible options (fail-closed): ${detail}`,
+      );
+    }
 
     const { synthesis, reviewProjections } = buildRealDepositAssetPackOptionSynthesis(
       {