V48 Gate 3 (implementation-only): fix typecheck for deposit synthesis schema and icons

- Align deposit synthesis Zod schema (optional measurements without .default)
  so factoryAgentWithPTRR accepts it under tsc
- Wrap Forced Inclusion/Exclusions Lucide icons so title tooltips do not break LucideProps
- Route and deposit page fixtures use formal absolute measurements, not placeholder kinds

Author: geraldarthurdavis

packages/pipelines/asset-pack/src/agents/implementation/deposit-asset-pack-synthesis-agent.ts

@@ -70,8 +70,10 @@ const candidateSchema = z.object({
   // Absolute measurements (quantity + quality material properties) are produced
   // by agent-measure-absolutes in Validation — NOT self-scored here. Optional
   // legacy record accepted for back-compat but ignored when absolutes attach.
-  measurements: z.record(z.string(), z.coerce.number().min(0).max(1)).optional().default({}),
-  measurementRationale: z.string().max(700).optional().default(''),
+  // Keep input/output Zod types aligned (no .default that widens _input vs output)
+  // so factoryAgentWithPTRR accepts the schema under tsc.
+  measurements: z.record(z.string(), z.coerce.number().min(0).max(1)).optional(),
+  measurementRationale: z.string().max(700).optional(),
   confidence: z.coerce.number().min(0).max(1),
   // Synthesized patch descriptor (path+op + summary) — Validation measures it.
   patch: patchSchema,

uapi/app/deposits/deposit-obfuscations-path-icons.tsx

@@ -21,12 +21,14 @@ export function DepositIncludePathsIcon({
   className?: string;
   title?: string;
 }) {
+  // Lucide icons do not accept `title`; wrap so hover tooltips still work.
   return (
-    <FolderPlus
-      className={className ?? `${ICON_CLASS} text-emerald-300/80`}
-      aria-hidden="true"
-      title={title}
-    />
+    <span title={title} className="inline-flex shrink-0">
+      <FolderPlus
+        className={className ?? `${ICON_CLASS} text-emerald-300/80`}
+        aria-hidden="true"
+      />
+    </span>
   );
 }
 
@@ -39,11 +41,12 @@ export function DepositExcludePathsIcon({
   title?: string;
 }) {
   return (
-    <FolderMinus
-      className={className ?? `${ICON_CLASS} text-rose-300/80`}
-      aria-hidden="true"
-      title={title}
-    />
+    <span title={title} className="inline-flex shrink-0">
+      <FolderMinus
+        className={className ?? `${ICON_CLASS} text-rose-300/80`}
+        aria-hidden="true"
+      />
+    </span>
   );
 }
 

uapi/tests/api/depositSynthesizeOptionsRoute.test.ts

@@ -89,7 +89,26 @@ const RAW_OPTIONS = [
     summary:
       'A source-safe slice describing the demo application capability, its entry points, and operational behavior for future reading demand.',
     coveredSourcePaths: ['README.md', 'src/app.py'],
-    measurements: { 'source-coverage': 0.6, 'demand-alignment': 0.7, 'reuse-likelihood': 0.5 },
+    // Formal absolutes (Validation measure-agent) are required by product projection.
+    absolutes: [
+      {
+        measurementKind: 'function-count',
+        label: 'Functions',
+        weight: 0.12,
+        volume: 0.5,
+        category: 'absolute',
+        magnitude: 6,
+        unit: 'functions',
+      },
+      {
+        measurementKind: 'correctness-estimate',
+        label: 'Correctness',
+        weight: 0.18,
+        volume: 0.72,
+        category: 'absolute',
+        unit: 'estimate',
+      },
+    ],
     measurementRationale: 'Covers the primary application path and documentation.',
     confidence: 0.8,
     patch: {

uapi/tests/depositPageClient.test.tsx

@@ -567,13 +567,26 @@ describe("DepositPageClient", () => {
       },
       measurements: [
         {
-          id: "deposit-option-real-1:source-coverage",
-          label: "Source coverage",
-          measurementKind: "source-coverage",
-          weight: 0.36,
-          volume: 0.62,
+          id: "deposit-option-real-1:function-count",
+          label: "Functions",
+          measurementKind: "function-count",
+          weight: 0.12,
+          volume: 0.5,
+          category: "absolute",
+          magnitude: 8,
+          unit: "functions",
           evidenceRoot: "deposit-option-measurement:22222222",
         },
+        {
+          id: "deposit-option-real-1:correctness-estimate",
+          label: "Correctness",
+          measurementKind: "correctness-estimate",
+          weight: 0.18,
+          volume: 0.72,
+          category: "absolute",
+          unit: "estimate",
+          evidenceRoot: "deposit-option-measurement:22222223",
+        },
       ],
       reviewBoundary: {
         state: "reviewable-source-safe-option",