V48: Purge settle/delivery concept leaks from synthesis

Synthesis never passes settlementBoundary (even null) into
reading telemetry/parity/rehearsal. Finish stores reviewUpload /
reviewReadiness — never deliveryMechanism.

Terminology: Settlement = BTD-BTC + system finalities;
Delivery = settled read AssetPack PR ship; both settle-only.

Author: geraldarthurdavis

packages/api/src/routes/asset-pack-pipeline.ts

@@ -1041,11 +1041,11 @@ export const POST = traceRoute('/executions', async (request: NextRequest) => {
             (execution as any).get?.('implementation', 'assetPackSynthesisArtifacts') ||
             writtenAssets ||
             undefined;
-          // Synthesis completion path: never project settleDelivery / settle PR.
-          // Buyer-repo settle surfaces come only from settle-asset-pack-pipeline runs.
-          const deliveryMechanism =
-            (execution as any).get?.('finish/asset_pack_completion', 'deliveryMechanism') ||
+          // Synthesis completion path: review readiness only — never Delivery/Settlement.
+          const reviewReadiness =
+            (execution as any).get?.('finish/asset_pack_completion', 'reviewReadiness') ||
             undefined;
+          const deliveryMechanism = reviewReadiness; // legacy alias for older readers
           const settleDelivery = undefined;
           const read =
             (execution as any).get?.('finish/asset_pack_completion', 'read') ||

packages/asset-packs-pipelines/domain/src/SETTLEMENT_BOUNDARY.md

@@ -1,42 +1,39 @@
-# Settlement / delivery ownership law
+# Settlement & Delivery ownership law
 
-## Exclusive owner
+## Exclusive definitions (settle-asset-pack-pipeline only)
 
-**`execution-pipeline-simple-settle-asset-pack`** (settle-asset-pack-pipeline) is the
-**only** product pipeline that may:
+| Term | Meaning | Owner |
+| --- | --- | --- |
+| **Settlement** | BTD–BTC payment observation + Bitcode System finalities (rights, ledger, read licenses) | **settle-asset-pack-pipeline only** |
+| **Delivery** | **Settled** Synthesized **Read** AssetPack(s) shipped as **buyer-repo PRs** | **settle-asset-pack-pipeline only** |
 
-- Observe BTC payment / finality
-- Build settlement rights / BTD unlock
-- Open or record buyer-repo **shippable** PRs
-- Emit **`settleDelivery`**, **`shippable`**, delivery unlock, settlement replay
+Neither word, nor their result surfaces (`settleDelivery`, `shippable`, delivery unlock, settlement rights boundary), may appear as synthesis algorithm outputs or Finish review-store names.
 
 ## Synthesis (deposit + read SDIVF)
 
-`execution-pipeline-sdivf-synthesize-deposits-asset-packs` and
-`execution-pipeline-sdivf-synthesize-reads-asset-packs` (and shared synthesis
-postprocess/Finish) **must not**:
+**May** produce:
 
-| Forbidden on synthesis | OK on synthesis |
-| --- | --- |
-| `settleDelivery` | `selectionEnvelope` / `options` |
-| `shippable` / buyer PR URL | `assetPackSynthesisArtifacts` |
-| Settlement rights delivery boundary | Source-safe **preview** / fee quote (selection UI) |
-| Delivery unlock after payment | `deliveryMechanismTemplate` (catalog only) |
-| Kind `settle_delivery` | Kind `deposit_options` / `read_options` / `asset_pack_synthesis` |
-
-## Shared library modules
+- Selection envelopes / options for `/deposits` or `/reads`
+- Synthesis artifacts (`assetPackSynthesisArtifacts`, measurements, patches)
+- Source-safe **preview** + fee quote for selection UI
+- Finish **review upload** / **review readiness** (user review on Bitcode — not Delivery)
 
-`asset-pack-settlement-rights-delivery.ts` (and related BTD/BTC statement helpers)
-live under `domain` as a **library** for the settle pipeline and host settle
-staging. They are **not** part of the synthesis algorithm.
+**Must not** produce or project:
 
-- **May import:** settle pipeline, host settle path after purchase
-- **Must not import/call from:** synthesis preprocess, synthesis postprocess,
-  deposit/read Finish agents, deposit/read phase runners
+| Forbidden | Why |
+| --- | --- |
+| `settlementBoundary` args (including `null`) on reading telemetry/parity/rehearsal | Even null is a concept leak into synthesis |
+| `settleDelivery`, `shippable`, PR URL | Delivery = settle only |
+| Settlement rights unlock / delivery unlock | Settlement + Delivery = settle only |
+| Finish fields named “delivery” for review upload | Use `reviewUpload` / `reviewReadiness` |
 
 ## Hand-off
 
-Read synthesis finishes with options for `/reads` selection and
-`nextPipeline: settle-asset-pack-pipeline`.  
-Deposit synthesis finishes with options for `/deposits` review.  
-**A separate settle run** performs payment + delivery.
+1. **Deposit synthesis** → options for depositor review → (later) deposit admission  
+2. **Read synthesis** → options for reader review → purchase → **separate settle run**  
+3. **Settle run** → Settlement (BTD-BTC + system finalities) → Delivery (PR of settled read pack)
+
+## Library modules
+
+`asset-pack-settlement-rights-delivery.ts` remains under domain as a **settle-pipeline library**.  
+Synthesis preprocess/postprocess/Finish must never call or project it.

packages/asset-packs-pipelines/domain/src/__tests__/deposit-agent-store-contract.test.ts

@@ -501,11 +501,11 @@ describe('deposit agent context/store contract', () => {
       // The exact Finish store keys — on the SHARED execution (cross-phase law),
       // where postprocess and the run-level surfaces resolve them.
       expect(shared.get('finish', 'uploadForReview')).toMatchObject({
-        deliveryMechanism: 'bitcode-review-upload',
+        kind: 'bitcode-review-upload',
         review: { surface: '/deposits', reviewFor: 'deposit-admission' },
         options,
       });
-      expect(shared.get('finish', 'deliveryMechanism')).toBe('bitcode-review-upload');
+      expect(shared.get('finish', 'reviewUpload')).toBe('bitcode-review-upload');
     });
 
     it('read mode: uploads the implementation synthesis artifacts for /reads purchase review', async () => {

packages/asset-packs-pipelines/domain/src/__tests__/finish-completion.test.ts

@@ -36,11 +36,12 @@ describe('finish AssetPack completion evidence', () => {
     expect((result as any).shippable).toBeUndefined();
     expect((result.deliveryMechanism as any)?.pullRequest).toBeUndefined();
     expect(result.summary).toContain('octocat/Spoon-Knife');
-    expect(result.deliveryMechanism?.readiness).toMatchObject({
+    expect(result.reviewReadiness?.readiness).toMatchObject({
       status: 'pending-user-review',
     });
-    expect(result.deliveryMechanism?.summary).toContain('octocat/Spoon-Knife');
+    expect(result.reviewReadiness?.summary).toContain('octocat/Spoon-Knife');
     expect(result.assetPackSynthesisArtifacts?.summary).toContain('octocat/Spoon-Knife');
+    expect((result as any).deliveryMechanism).toBeUndefined();
   });
 
   it('ignores settle shippable on the EE — synthesis never emits settle surfaces', async () => {

packages/asset-packs-pipelines/domain/src/__tests__/finish-upload-for-review.test.ts

@@ -1,15 +1,7 @@
 // @ts-nocheck
 /**
- * Finish law (V48 Gate 3): BOTH synthesis modes finish by uploading the
- * synthesized AssetPack artifacts to Bitcode for USER review — deposit before
- * Depository admission, read before purchase. Opening a pull request is NOT
- * part of synthesis (PR/settlement delivery is reserved for the future Gate-6
- * SettleAssetPack pipeline).
- *
- * Pins the upload-for-review agent's behavior: mode-appropriate review surface,
- * 'bitcode-review-upload' delivery mechanism (never a PR shape), resolution of
- * the Implementation stores from ANCESTOR nodes (node-local get + ancestors-only
- * findUp), input spreading, and the finish stores it writes.
+ * Finish: store synthesized artifacts for USER review (not Delivery).
+ * Delivery = settle PR ship of settled read packs only.
  */
 import { Execution } from '@bitcode/execution-generics';
 import runUploadAssetPacksForReviewAgent from '../agents/finish/upload-asset-packs-for-review-agent';
@@ -21,47 +13,45 @@ const DEPOSIT_OPTIONS = [
 ];
 
 describe('upload-asset-packs-for-review Finish agent', () => {
-  it('deposit: uploads the synthesized options for /deposits admission review (no PR fields)', async () => {
+  it('deposit: stores synthesized options for /deposits review (no Delivery/PR)', async () => {
     const root = new Execution('pipeline:finish-upload-deposit');
     storeSynthesizeAssetPacksMode(root, 'deposit');
     root.store('implementation', 'options', DEPOSIT_OPTIONS);
     root.store('implementation', 'summary', 'Two measured deposit options.');
 
-    // Finish runs on a descendant node; the stores resolve via the upward walk.
     const finishNode = root.child('seq-3').child('seq-0');
     const input = { carried: 'from-validation' };
     const result = await runUploadAssetPacksForReviewAgent(input, finishNode);
 
     expect(result).toMatchObject({
       success: true,
-      carried: 'from-validation', // input is spread through
-      deliveryMechanism: 'bitcode-review-upload',
+      carried: 'from-validation',
+      kind: 'bitcode-review-upload',
       review: {
         surface: '/deposits',
         reviewFor: 'deposit-admission',
         decision: 'pending-user-review',
       },
       options: DEPOSIT_OPTIONS,
       sourceSummary: 'Two measured deposit options.',
-      summary: 'Synthesized AssetPacks uploaded to Bitcode for deposit review.',
+      summary: 'Synthesized AssetPacks stored for deposit review on Bitcode.',
     });
 
-    // Never a pull-request shippable.
     expect(result).not.toHaveProperty('prUrl');
     expect(result).not.toHaveProperty('pullRequest');
+    expect(result).not.toHaveProperty('deliveryMechanism');
+    expect(result).not.toHaveProperty('settleDelivery');
 
-    // The upload is recorded on the SHARED (root) execution for downstream
-    // completion (cross-phase store-visibility law) — the finish node still
-    // resolves it via the upward walk.
     expect(root.get('finish', 'uploadForReview')).toMatchObject({
-      deliveryMechanism: 'bitcode-review-upload',
+      kind: 'bitcode-review-upload',
       review: { reviewFor: 'deposit-admission' },
     });
-    expect(root.get('finish', 'deliveryMechanism')).toBe('bitcode-review-upload');
-    expect(finishNode.findUp('finish', 'deliveryMechanism')).toBe('bitcode-review-upload');
+    expect(root.get('finish', 'reviewUpload')).toBe('bitcode-review-upload');
+    expect(finishNode.findUp('finish', 'reviewUpload')).toBe('bitcode-review-upload');
+    expect(root.get('finish', 'deliveryMechanism')).toBeUndefined();
   });
 
-  it('read: uploads the synthesis artifacts for /reads purchase review', async () => {
+  it('read: stores synthesis artifacts for /reads review (not Delivery)', async () => {
     const root = new Execution('pipeline:finish-upload-read');
     storeSynthesizeAssetPacksMode(root, 'read');
     const artifacts = {
@@ -73,15 +63,16 @@ describe('upload-asset-packs-for-review Finish agent', () => {
     const result = await runUploadAssetPacksForReviewAgent({}, root.child('seq-3'));
 
     expect(result).toMatchObject({
-      deliveryMechanism: 'bitcode-review-upload',
+      kind: 'bitcode-review-upload',
       review: {
         surface: '/reads',
         reviewFor: 'purchase',
         decision: 'pending-user-review',
       },
       artifacts,
-      summary: 'Synthesized AssetPacks uploaded to Bitcode for read review.',
+      summary: 'Synthesized AssetPacks stored for read review on Bitcode.',
     });
+    expect(result).not.toHaveProperty('deliveryMechanism');
   });
 
   it('defaults to the read lens when no mode was stored', async () => {

packages/asset-packs-pipelines/domain/src/__tests__/upload-asset-packs-for-review.test.ts

@@ -36,7 +36,8 @@ describe('runUploadAssetPacksForReviewAgent', () => {
     const result = await runUploadAssetPacksForReviewAgent({ runId: 'run-1' }, finishExec);
 
     expect(result.success).toBe(true);
-    expect(result.deliveryMechanism).toBe('bitcode-review-upload');
+    expect(result.kind).toBe('bitcode-review-upload');
+    expect(result).not.toHaveProperty('deliveryMechanism');
     expect(result.review).toEqual({
       surface: '/deposits',
       reviewFor: 'deposit-admission',
@@ -45,20 +46,20 @@ describe('runUploadAssetPacksForReviewAgent', () => {
     expect(result.options).toBe(OPTIONS); // the synthesized options ride in the upload record
     expect(result.assetPack).toEqual({ repository: { fullName: 'org/repo' } });
     expect(result.sourceSummary).toBe('Synthesized 1 measured deposit AssetPack patch(es).');
-    expect(result.summary).toBe('Synthesized AssetPacks uploaded to Bitcode for deposit review.');
+    expect(result.summary).toBe('Synthesized AssetPacks stored for deposit review on Bitcode.');
     // The runner spreads its input into its result (Finish output chain).
     expect(result.runId).toBe('run-1');
 
     // Cross-phase law: the upload record is stored on the SHARED (root)
     // execution — where postprocess and the run-level surfaces resolve it —
     // not on the isolated Finish sibling.
     expect(outer.get('finish', 'uploadForReview')).toMatchObject({
-      deliveryMechanism: 'bitcode-review-upload',
+      kind: 'bitcode-review-upload',
       review: { surface: '/deposits', reviewFor: 'deposit-admission' },
     });
-    expect(outer.get('finish', 'deliveryMechanism')).toBe('bitcode-review-upload');
+    expect(outer.get('finish', 'reviewUpload')).toBe('bitcode-review-upload');
     // Still resolvable from the Finish subtree via the upward walk.
-    expect(finishExec.findUp('finish', 'deliveryMechanism')).toBe('bitcode-review-upload');
+    expect(finishExec.findUp('finish', 'reviewUpload')).toBe('bitcode-review-upload');
   });
 
   it('read mode: uploads for /reads purchase review and carries the synthesis artifacts', async () => {
@@ -76,7 +77,8 @@ describe('runUploadAssetPacksForReviewAgent', () => {
       decision: 'pending-user-review',
     });
     expect(result.artifacts).toBe(artifacts);
-    expect(result.summary).toBe('Synthesized AssetPacks uploaded to Bitcode for read review.');
+    expect(result.kind).toBe('bitcode-review-upload');
+    expect(result.summary).toBe('Synthesized AssetPacks stored for read review on Bitcode.');
   });
 
   it('defaults to read review when no mode was stored', async () => {
@@ -105,7 +107,7 @@ describe('runUploadAssetPacksForReviewAgent', () => {
     }
     // The upload decision is the user's, pending — never an auto-opened PR.
     expect(stored.review.decision).toBe('pending-user-review');
-    expect(outer.get('finish', 'deliveryMechanism')).toBe('bitcode-review-upload');
+    expect(outer.get('finish', 'reviewUpload')).toBe('bitcode-review-upload');
   });
 });
 

packages/asset-packs-pipelines/domain/src/agents/finish/asset-pack-completion-agent.ts

@@ -27,8 +27,8 @@ const AssetPackSynthesisArtifactsSchema = WrittenAssetsSchema.extend({
   reviewNotes: z.array(z.string()).optional(),
 });
 
-/** Review readiness only — no pullRequest (settle exclusive). */
-const DeliveryMechanismSchema = z.object({
+/** User-review readiness only — never pullRequest / delivery (settle exclusive). */
+const ReviewReadinessSchema = z.object({
   summary: z.string().nullable().optional(),
   readiness: z
     .object({
@@ -44,13 +44,13 @@ const DeliveryMechanismSchema = z.object({
 export const AssetPackCompletionOutputSchema = z.object({
   /**
    * Synthesis completion summary (markdown). Primary Finish evidence for SDIVF.
-   * Settlement (settleDelivery / buyer PR) is exclusive to settle-asset-pack-pipeline
-   * and is never authored or passed through by synthesis Finish.
+   * Settlement = BTD-BTC + Bitcode System finalities (settle pipeline only).
+   * Delivery = settled read AssetPack PR ship (settle pipeline only).
    */
   summary: z.string().optional(),
   assetPackSynthesisArtifacts: AssetPackSynthesisArtifactsSchema.optional(),
   writtenAssets: WrittenAssetsSchema.optional(),
-  deliveryMechanism: DeliveryMechanismSchema.optional(),
+  reviewReadiness: ReviewReadinessSchema.optional(),
   read: z.string().optional(),
   writtenAssetType: z.string().optional(),
   processingStats: z.object({
@@ -100,7 +100,7 @@ const AssetPackCompletionAgent = factoryAgentWithSingleStep<any, AssetPackComple
       (execution as any).prompt?.setSpecificExecution(
         'specific_execution:output:shape',
         (
-          'Output JSON with keys: summary, assetPackSynthesisArtifacts{fileChanges,summary,proofEvidence?,reviewNotes?}, writtenAssets{fileChanges,summary}, deliveryMechanism{summary,readiness}, processingStats{…}, repoSnapshot{org,repo,branch,commit}. Never settleDelivery / settlePassThrough / buyer-repo PR — those are settle-asset-pack-pipeline only. SDIVF Finish closes synthesis evidence only.'
+          'Output JSON with keys: summary, assetPackSynthesisArtifacts{…}, writtenAssets{…}, reviewReadiness{summary,readiness}, processingStats{…}, repoSnapshot{…}. Never settlement, delivery, settleDelivery, or buyer-repo PR — those are settle-asset-pack-pipeline only (BTD-BTC finality + PR ship of settled read packs).'
         ) as unknown as PromptPart
       );
     } catch {}
@@ -223,8 +223,8 @@ const AssetPackCompletionAgent = factoryAgentWithSingleStep<any, AssetPackComple
         : {
             ...writtenAssets,
           };
-    // Review readiness only — never pullRequest / settleDelivery / shippable.
-    const deliveryMechanism = {
+    // User-review readiness only — never pullRequest / settleDelivery / shippable / Delivery.
+    const reviewReadiness = {
       summary,
       readiness: deliveryReadiness,
     };
@@ -233,7 +233,7 @@ const AssetPackCompletionAgent = factoryAgentWithSingleStep<any, AssetPackComple
       summary,
       assetPackSynthesisArtifacts,
       writtenAssets,
-      deliveryMechanism,
+      reviewReadiness,
       read: read || undefined,
       writtenAssetType: dtype || undefined,
       processingStats,
@@ -246,7 +246,7 @@ const AssetPackCompletionAgent = factoryAgentWithSingleStep<any, AssetPackComple
       (execution as any).store?.('finish/asset_pack_completion', 'summary', summary as any);
       (execution as any).store?.('finish/asset_pack_completion', 'assetPackSynthesisArtifacts', assetPackSynthesisArtifacts as any);
       (execution as any).store?.('finish/asset_pack_completion', 'writtenAssets', writtenAssets as any);
-      (execution as any).store?.('finish/asset_pack_completion', 'deliveryMechanism', deliveryMechanism as any);
+      (execution as any).store?.('finish/asset_pack_completion', 'reviewReadiness', reviewReadiness as any);
       (execution as any).store?.('finish/asset_pack_completion', 'read', read || undefined);
       (execution as any).store?.('finish/asset_pack_completion', 'writtenAssetType', dtype || undefined);
       (execution as any).store?.('finish/asset_pack_completion', 'processingStats', processingStats as any);

packages/asset-packs-pipelines/domain/src/agents/finish/deposit-store-artifacts-agent.ts

@@ -124,11 +124,10 @@ export default async function runDepositStoreArtifactsAgent(input: any, executio
   };
 
   storeCrossPhaseArtifact(execution, 'finish', 'storedArtifacts', artifactBundle);
-  // Review-admission upload only — not SettleAssetPacks destination delivery
-  // (PR/settlement deliver agents run during settlement procedures).
+  // User-review store only — not Delivery (PR ship is settle-pipeline exclusive).
   storeCrossPhaseArtifact(execution, 'finish', 'uploadForReview', {
     success: true,
-    deliveryMechanism: 'bitcode-review-upload',
+    kind: 'bitcode-review-upload',
     review: {
       surface: '/deposits',
       reviewFor: 'deposit-admission',
@@ -138,7 +137,7 @@ export default async function runDepositStoreArtifactsAgent(input: any, executio
     artifacts: artifactBundle,
     summary: `Stored ${assetPacks.length} AssetPack artifact(s) for deposit review.`,
   });
-  storeCrossPhaseArtifact(execution, 'finish', 'deliveryMechanism', 'bitcode-review-upload');
+  storeCrossPhaseArtifact(execution, 'finish', 'reviewUpload', 'bitcode-review-upload');
 
   // Durable write hook (Supabase / DB) — Host/dispatch injects deposit:persistArtifacts.
   let persistResult: { ok: boolean; mode: string; detail?: string } = {