V48: Finish settle ownership outside synthesis

Remove settlement-rights build from synthesis preprocess.
Document exclusive settle pipeline ownership. Synthesis
paths never invoke settle/delivery builders.

Author: geraldarthurdavis

packages/asset-packs-pipelines/domain/README.md

@@ -1,14 +1,17 @@
-# AssetPack Pipeline
+# AssetPack Pipeline Domain
 
-Canonical package owner for the Bitcode phased pipeline corridor.
-This package turns a measured Bitcode Read into AssetPack synthesis artifacts,
-Exchange-stored AssetPack evidence, and optional connected-interface
-delivery-mechanism artifacts.
+Canonical package owner for **AssetPack synthesis** (deposit + read SDIVF) and
+shared measurement/selection primitives.
+
+**Settlement and buyer-repo delivery are not this package’s product algorithm.**
+They are exclusive to `execution-pipeline-simple-settle-asset-pack`. See
+[`src/SETTLEMENT_BOUNDARY.md`](src/SETTLEMENT_BOUNDARY.md).
+
+Synthesis terminals: **selection envelopes / options** for `/deposits` or
+`/reads` — never `settleDelivery` / shippable PR.
 
 Active route and payload seams use Bitcode nouns: `definitionOfRead`, `read`,
-`writtenAssetType`, `writtenAssets`, `Finish`, `Delivering`, and `SDIVF`.
-Compatibility payload keys are subordinate mirrors and do not define product
-semantics.
+`writtenAssetType`, `writtenAssets`, `selectionEnvelope`, and `SDIVF`.
 
 ## SDIVF Shape
 
@@ -17,7 +20,7 @@ semantics.
 3. **Discovery** - source-grounded research, codebase search, file selection, and approach planning.
 4. **Implementation** - AssetPack synthesis artifacts using Divide, Apply, and Correct agents.
 5. **Validation** - Read satisfaction, proof posture, and readiness-to-Finish checks.
-6. **Finish** - save result state, summarize AssetPack evidence, and run Delivering when requested.
+6. **Finish** - store artifacts, ledgerize, emit selection envelope (options for deposit or read UI). **No settle / no buyer-repo PR.**
 
 The `Discovery -> Implementation -> Validation` loop may iterate up to the
 configured limit before Finish.
@@ -42,8 +45,8 @@ AssetPackPipeline (SDIVF with DIV iteration)
 │ └── Validation
 └── Finish
  ├── Save AssetPack synthesis artifacts and Exchange evidence
- ├── Produce AssetPack completion summary
- └── Deliver AssetPacks or AssetPackPartials to connected destinations
+ ├── Produce selection envelope / options for UI
+ └── (Settlement + buyer PR only on settle-asset-pack-pipeline — separate run)
 ```
 
 ## Usage

packages/asset-packs-pipelines/domain/src/SETTLEMENT_BOUNDARY.md

@@ -0,0 +1,42 @@
+# Settlement / delivery ownership law
+
+## Exclusive owner
+
+**`execution-pipeline-simple-settle-asset-pack`** (settle-asset-pack-pipeline) is the
+**only** product pipeline that may:
+
+- Observe BTC payment / finality
+- Build settlement rights / BTD unlock
+- Open or record buyer-repo **shippable** PRs
+- Emit **`settleDelivery`**, **`shippable`**, delivery unlock, settlement replay
+
+## Synthesis (deposit + read SDIVF)
+
+`execution-pipeline-sdivf-synthesize-deposits-asset-packs` and
+`execution-pipeline-sdivf-synthesize-reads-asset-packs` (and shared synthesis
+postprocess/Finish) **must not**:
+
+| Forbidden on synthesis | OK on synthesis |
+| --- | --- |
+| `settleDelivery` | `selectionEnvelope` / `options` |
+| `shippable` / buyer PR URL | `assetPackSynthesisArtifacts` |
+| Settlement rights delivery boundary | Source-safe **preview** / fee quote (selection UI) |
+| Delivery unlock after payment | `deliveryMechanismTemplate` (catalog only) |
+| Kind `settle_delivery` | Kind `deposit_options` / `read_options` / `asset_pack_synthesis` |
+
+## Shared library modules
+
+`asset-pack-settlement-rights-delivery.ts` (and related BTD/BTC statement helpers)
+live under `domain` as a **library** for the settle pipeline and host settle
+staging. They are **not** part of the synthesis algorithm.
+
+- **May import:** settle pipeline, host settle path after purchase
+- **Must not import/call from:** synthesis preprocess, synthesis postprocess,
+  deposit/read Finish agents, deposit/read phase runners
+
+## Hand-off
+
+Read synthesis finishes with options for `/reads` selection and
+`nextPipeline: settle-asset-pack-pipeline`.  
+Deposit synthesis finishes with options for `/deposits` review.  
+**A separate settle run** performs payment + delivery.

packages/asset-packs-pipelines/domain/src/index.ts

@@ -1,10 +1,12 @@
 /**
- * AssetPack Pipeline
+ * AssetPack domain library for **synthesis** SDIVF product pipelines
+ * (deposit + read) and shared measurement/selection primitives.
  *
- * Bitcode SDIVF pipeline runs (Setup → Discovery → Implementation → Validation
- * → Finish) that satisfy Reads, synthesize AssetPack artifacts and Exchange
- * evidence, and use Finish-phase Delivering only for connected-interface
- * delivery.
+ * Settlement / buyer-repo delivery / shippable PR are **not** synthesis work.
+ * They are exclusive to `execution-pipeline-simple-settle-asset-pack`.
+ * Modules such as `asset-pack-settlement-rights-delivery` remain in this package
+ * only as a library for the settle pipeline / host settle path — synthesis
+ * preprocess/postprocess/Finish must never invoke or project them.
  */
 
 import { Executor, Execution } from '@bitcode/execution-generics';
@@ -34,10 +36,7 @@ import {
   buildAssetPackPreviewBoundary,
   persistAssetPackPreviewBoundary,
 } from './asset-pack-preview-boundary';
-import {
-  buildAssetPackSettlementRightsDeliveryBoundary,
-  persistAssetPackSettlementRightsDeliveryBoundary,
-} from './asset-pack-settlement-rights-delivery';
+// Intentionally no settlement-rights import for synthesis preprocess.
 import {
   buildReadingOperationalTelemetryRepairReadback,
   persistReadingOperationalTelemetryRepairReadback,
@@ -306,29 +305,15 @@ function factoryPreprocess(): Executor<any, any> {
         processedInput.sourceSafePreview = assetPackPreviewBoundary.sourceSafePreview;
         processedInput.assetPackPreviewBoundary = assetPackPreviewBoundary;
         processedInput.assetPackQuoteReceipt = assetPackPreviewBoundary.quoteReceipt;
-        const suppliedSettlement =
-          processedInput?.settlementObservation ||
-          processedInput?.paymentObservation ||
-          processedInput?.btcPaymentObservation ||
-          null;
-        if (suppliedSettlement) {
-          const settlementBoundary = buildAssetPackSettlementRightsDeliveryBoundary({
-            previewBoundary: assetPackPreviewBoundary,
-            paymentObservation: suppliedSettlement,
-            finality: processedInput?.settlementFinality || processedInput?.btcFinality || undefined,
-            readerWalletId: processedInput?.readerWalletId || null,
-            depositorWalletId: processedInput?.depositorWalletId || null,
-            pullRequestTarget: processedInput?.deliveryTarget || null,
-          });
-          persistAssetPackSettlementRightsDeliveryBoundary(execution, settlementBoundary);
-          persistAssetPackSettlementRightsDeliveryBoundary(execution.parent as any, settlementBoundary);
-          processedInput.assetPackSettlementRightsDeliveryBoundary = settlementBoundary;
-          processedInput.assetPackSettlementReplayReceipt = settlementBoundary.replayReceipt;
-          processedInput.assetPackDeliveryUnlock = settlementBoundary.deliveryUnlock;
-        }
+        // Never build settlement rights / delivery unlock during synthesis preprocess.
+        // Payment observation + PR unlock belong exclusively to settle-asset-pack-pipeline.
+        delete processedInput.assetPackSettlementRightsDeliveryBoundary;
+        delete processedInput.assetPackSettlementReplayReceipt;
+        delete processedInput.assetPackDeliveryUnlock;
       }
     } catch {}
     try {
+      // settlementBoundary always null on synthesis preprocess path.
       const operationalReadback = buildReadingOperationalTelemetryRepairReadback({
         runId: String(execution.id || processedInput?.transactionId || processedInput?.id || ''),
         readNeedRuntime:
@@ -346,11 +331,7 @@ function factoryPreprocess(): Executor<any, any> {
           (execution.get('asset-pack/preview', 'boundary') as any) ||
           ((execution.parent as any)?.get?.('asset-pack/preview', 'boundary') as any) ||
           null,
-        settlementBoundary:
-          processedInput?.assetPackSettlementRightsDeliveryBoundary ||
-          (execution.get('asset-pack/settlement', 'boundary') as any) ||
-          ((execution.parent as any)?.get?.('asset-pack/settlement', 'boundary') as any) ||
-          null,
+        settlementBoundary: null,
         createdAt: new Date().toISOString(),
       });
       persistReadingOperationalTelemetryRepairReadback(execution, operationalReadback);
@@ -375,11 +356,7 @@ function factoryPreprocess(): Executor<any, any> {
           (execution.get('asset-pack/preview', 'boundary') as any) ||
           ((execution.parent as any)?.get?.('asset-pack/preview', 'boundary') as any) ||
           null,
-        settlementBoundary:
-          processedInput?.assetPackSettlementRightsDeliveryBoundary ||
-          (execution.get('asset-pack/settlement', 'boundary') as any) ||
-          ((execution.parent as any)?.get?.('asset-pack/settlement', 'boundary') as any) ||
-          null,
+        settlementBoundary: null,
         operationalReadback,
       });
       persistReadingInterfaceProductParity(execution, interfaceParity);
@@ -409,11 +386,7 @@ function factoryPreprocess(): Executor<any, any> {
           (execution.get('asset-pack/preview', 'boundary') as any) ||
           ((execution.parent as any)?.get?.('asset-pack/preview', 'boundary') as any) ||
           null,
-        settlementBoundary:
-          processedInput?.assetPackSettlementRightsDeliveryBoundary ||
-          (execution.get('asset-pack/settlement', 'boundary') as any) ||
-          ((execution.parent as any)?.get?.('asset-pack/settlement', 'boundary') as any) ||
-          null,
+        settlementBoundary: null,
         operationalReadback,
         interfaceParity,
       });
@@ -664,6 +637,10 @@ export * from './depository-search';
 export * from './depository-supply-index';
 export * from './read-fits-finding-runtime';
 export * from './asset-pack-preview-boundary';
+/**
+ * Settle-pipeline library only (rights unlock / delivery after payment).
+ * Synthesis deposit/read SDIVF must not call these builders or project their results.
+ */
 export * from './asset-pack-settlement-rights-delivery';
 export * from './reading-operational-telemetry-repair-readback';
 export * from './reading-interface-product-parity';

packages/asset-packs-pipelines/execution-pipeline-sdivf-synthesize-deposits-asset-packs/src/index.ts

@@ -9,6 +9,9 @@
  *
  * Depositor supplies a repository; pipeline synthesizes DepositSynthesizedAssetPack
  * options for Depository review/admission. Not mode/lens-parameterized.
+ *
+ * Settlement / buyer-repo delivery / settleDelivery are **not** this pipeline —
+ * see settle-asset-pack-pipeline (ExecutionPipelineSimpleSettleAssetPack).
  */
 
 import type { Execution } from '@bitcode/execution-generics';

packages/asset-packs-pipelines/execution-pipeline-simple-settle-asset-pack/src/index.ts

@@ -3,6 +3,10 @@
  *
  * Product pipeline name: **settle-asset-pack-pipeline** (singular AssetPack).
  *
+ * **Exclusive owner** of settlement and buyer-repo delivery: BTC payment,
+ * BTD rights, shippable PR, settleDelivery. Synthesis deposit/read SDIVF
+ * pipelines must not author those surfaces (see domain SETTLEMENT_BOUNDARY.md).
+ *
  * Hierarchy (left→right): Execution → Pipeline → Simple → SettleAssetPack
  *   factoryExecutionPipelineSimpleSettleAssetPack
  *     → ExecutionPipelineSimpleSettleAssetPack