Skip to content

Handle composite IDs, refactor tests#4

Merged
bruhad-dave merged 7 commits into
developfrom
feature/handle_composite_ids
Sep 4, 2025
Merged

Handle composite IDs, refactor tests#4
bruhad-dave merged 7 commits into
developfrom
feature/handle_composite_ids

Conversation

@bruhad-dave

@bruhad-dave bruhad-dave commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator
  • Added support to handle cases where key/ID column values in input tabular files are not unique, but can be made unique when joined with values from another column (eg. cases where sample_id may not have all unique values, but sample_id when combined with, for example, something like replicate_number, forms a unique ID)
  • Refactored tests to reduce use of file comparisons of test outputs against fixed expected files
  • Added explicit handling of "" as None rather than string, updated corresponding test

@bruhad-dave bruhad-dave self-assigned this Sep 1, 2025
Comment thread validation_toolkit/TableValidator/file_io.py Outdated
@bruhad-dave bruhad-dave merged commit b55140d into develop Sep 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants