Skip to content

Feature #10 move pictures#54

Open
ojob wants to merge 3 commits intoadrienverge:masterfrom
ojob:feature-#10-move-pictures
Open

Feature #10 move pictures#54
ojob wants to merge 3 commits intoadrienverge:masterfrom
ojob:feature-#10-move-pictures

Conversation

@ojob
Copy link

@ojob ojob commented Nov 11, 2017

Updating README file following pull request #46

Joël Bourgault added 2 commits November 11, 2017 09:35
)

Signed-off-by: Joël Bourgault <joel.bourgault@gmail.com>
Signed-off-by: Joël Bourgault <joel.bourgault@gmail.com>
@ojob
Copy link
Author

ojob commented Nov 11, 2017

Still same error reported by flake8-import-order. Let's see if people on Stackoverflow may help me...

Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Almost ready to merge:

  • just one remark on the wording,
  • like in other PRs, please use Linux-style commit messages (explicit titles, no fixed english syntax add-ons); see examples in history: 92f21d3 07e0010 f86b361 etc.

poster image can be saved in any size.
arranged to fill the whole poster, then you can swap photos in the generated
grid or move them in their cells, and change the final dimensions, border
style, and output image quality. Eventually the final poster image can be saved.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in any size is important here: can you restore it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought "in any size" would be covered by "change the final dimensions", that's why I removed it. I'll change it back.

@ojob
Copy link
Author

ojob commented Nov 12, 2017

I must admit I'm used to work with the issue list always near; I'll take care in the future. Thanks for the update, and for the comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants