Skip to content

refactor: add support for go1.16's WalkDir#22

Open
darkliquid wants to merge 3 commits into
adrg:masterfrom
darkliquid:dir-walk
Open

refactor: add support for go1.16's WalkDir#22
darkliquid wants to merge 3 commits into
adrg:masterfrom
darkliquid:dir-walk

Conversation

@darkliquid

Copy link
Copy Markdown
Contributor

Add support for using the faster WalkDir method when building against
go1.16.

This hopefully addresses the concerns with #15 by making this backwards compatible.

@codecov

codecov Bot commented Mar 28, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.53%. Comparing base (0b7b89d) to head (853d54f).
⚠️ Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
finder_dirwalk.go 58.33% 3 Missing and 2 partials ⚠️
finder_walk.go 58.33% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage   10.34%   66.53%   +56.18%     
===========================================
  Files           4        6        +2     
  Lines         232      248       +16     
===========================================
+ Hits           24      165      +141     
+ Misses        208       71      -137     
- Partials        0       12       +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add support for using the faster WalkDir method when building against
go1.16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant