Skip to content

Use optimized filepath.WalkDir function instead of filepath.Walk #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hismailbulut wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use optimized filepath.WalkDir function instead of filepath.Walk #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions finder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package sysfont

import (
"os"
"io/fs"
"path/filepath"
"strings"

Expand Down Expand Up @@ -32,11 +32,11 @@ func NewFinder(opts *FinderOpts) *Finder {
}

var fonts []*Font
walker := func(filename string, info os.FileInfo, err error) error {
walker := func(filename string, d fs.DirEntry, err error) error {
if err != nil {
return err
}
if info.IsDir() {
if d.IsDir() {
return nil
}

Expand All @@ -60,7 +60,7 @@ func NewFinder(opts *FinderOpts) *Finder {

// Traverse OS font directories.
for _, dir := range xdg.FontDirs {
if err := filepath.Walk(dir, walker); err != nil {
if err := filepath.WalkDir(dir, walker); err != nil {
continue
}
}
Expand Down