MWPW-191453#753
Open
sanjayms01 wants to merge 1 commit intostagefrom
Open
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MWPW-191453
Summary
This PR fixes RTL (right-to-left) layout issues and an error toast opacity bug in the Unity prompt bar CSS components. Physical CSS properties have been replaced with logical equivalents to ensure correct rendering in RTL locales, and an opacity rule has been added to fade non-alert elements when an error toast is visible.
Changes
unitylibs/core/widgets/prompt-bar/prompt-bar.cssdirection: inheritto.inp-wrapto support RTL text directionpadding: 20px 22px 18px 26pxwith logicalpadding-block/padding-inlineequivalentsmargin: 0 5px 0 0on.inp-fieldwithmargin-inline-end: 5pxmargin-left: 16pxwithmargin-inline-start: 16pxon upload-marquee autocompletepadding-left: 0withpadding-inline-start: 0margin: 40px 40px 0 0in mobile breakpoint withmargin-block/margin-inlineequivalentsunitylibs/core/widgets/prompt-bar-style/prompt-bar-style.cssdirection: inheritto.inp-wrapand the grid.inp-wraprulemargin: 0 5px 0 0withmargin-inline-end: 5px.unity-slf-style-containerand non-alert.ex-unity-wrapchildren to0.05when.alert-holder.showis presentgrid-template-columns: 1fr autotominmax(0, 1fr) autoto prevent grid overflow in RTLjustify-content: flex-start/flex-endwith logicalstart/endvaluesTests added/modified
test/core/widgets/prompt-bar-style.test.js— new test file covering all CSS changestest/core/widgets/prompt-bar.test.js— new test file covering all CSS changesJira
https://jira.corp.adobe.com/browse/MWPW-191453