Skip to content

MWPW-191453#753

Open
sanjayms01 wants to merge 1 commit intostagefrom
ado-MWPW-191453-a5b06aa0
Open

MWPW-191453#753
sanjayms01 wants to merge 1 commit intostagefrom
ado-MWPW-191453-a5b06aa0

Conversation

@sanjayms01
Copy link
Copy Markdown
Collaborator

@sanjayms01 sanjayms01 commented Apr 26, 2026

MWPW-191453

Summary

This PR fixes RTL (right-to-left) layout issues and an error toast opacity bug in the Unity prompt bar CSS components. Physical CSS properties have been replaced with logical equivalents to ensure correct rendering in RTL locales, and an opacity rule has been added to fade non-alert elements when an error toast is visible.

Changes

unitylibs/core/widgets/prompt-bar/prompt-bar.css

  • Added direction: inherit to .inp-wrap to support RTL text direction
  • Replaced physical padding: 20px 22px 18px 26px with logical padding-block/padding-inline equivalents
  • Replaced margin: 0 5px 0 0 on .inp-field with margin-inline-end: 5px
  • Replaced margin-left: 16px with margin-inline-start: 16px on upload-marquee autocomplete
  • Replaced padding-left: 0 with padding-inline-start: 0
  • Replaced physical margin: 40px 40px 0 0 in mobile breakpoint with margin-block/margin-inline equivalents

unitylibs/core/widgets/prompt-bar-style/prompt-bar-style.css

  • Added direction: inherit to .inp-wrap and the grid .inp-wrap rule
  • Replaced margin: 0 5px 0 0 with margin-inline-end: 5px
  • Added opacity rule: fades .unity-slf-style-container and non-alert .ex-unity-wrap children to 0.05 when .alert-holder.show is present
  • Changed grid-template-columns: 1fr auto to minmax(0, 1fr) auto to prevent grid overflow in RTL
  • Replaced justify-content: flex-start/flex-end with logical start/end values

Tests added/modified

  • test/core/widgets/prompt-bar-style.test.js — new test file covering all CSS changes
  • test/core/widgets/prompt-bar.test.js — new test file covering all CSS changes
  • Minor lint/style fixes across several existing test files

Jira

https://jira.corp.adobe.com/browse/MWPW-191453

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 26, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant