Skip to content

ADO-fix (MWPW-190444): remove 512x512 minimum dimension restriction for Firefly uploads#750

Open
dstrong23 wants to merge 1 commit intostagefrom
ado-MWPW-190444-remove-512-dimension
Open

ADO-fix (MWPW-190444): remove 512x512 minimum dimension restriction for Firefly uploads#750
dstrong23 wants to merge 1 commit intostagefrom
ado-MWPW-190444-remove-512-dimension

Conversation

@dstrong23
Copy link
Copy Markdown
Collaborator

@dstrong23 dstrong23 commented Apr 22, 2026

Resolves: MWPW-190444

Test URLs:

Fixes MWPW-190444 — removes the 512×512 minimum image dimension restriction from Firefly upload flows.

The 512×512 minimum was a product-specified requirement that has since been lifted. The restriction was enforced on the primary upload path but was never applied to the Edit flow (reference image upload from device), causing an inconsistency. Removing the config entries resolves both issues simultaneously: the primary upload no longer blocks small images, and the Edit flow inconsistency is moot.

Root Cause
The 512×512 minimum dimension was hardcoded in target-config.json under limits-firefly as minHeight: 512 and minWidth: 512. This config is merged into this.limits in action-binder.js at construction time and evaluated in checkImageDimensions(). Because isMinLimits is only truthy when both minWidth and minHeight are present, removing these keys from the config causes the minimum-dimension check block to become a no-op with no JS changes required.

The Edit flow (reference image upload via the prompt-bar widget) bypassed uploadImage() entirely and therefore never called checkImageDimensions(), which is why the inconsistency existed. Both paths now behave identically: no minimum dimension is enforced.

Changes
File: unitylibs/core/workflow/workflow-upload/target-config.json

Removed minHeight: 512 from limits-firefly
Removed minWidth: 512 from limits-firefly
All other limits (maxFileSize, allowedFileTypes) are unchanged
Photoshop and Lightroom limits (limits-photoshop, limits-lightroom) are completely unaffected
No JavaScript changes are required.

Verification
Confirmed minHeight/minWidth only exist in target-config.json in this repo (no other JS files hardcode these values)
Confirmed fallback.js reference to minHeight is a CSS property on a browser-compatibility banner — unrelated
Confirmed no API endpoint dynamically supplies dimension limits — this config is the single source of truth
Testing
Verify images smaller than 512×512 can be uploaded via the main upload flow on Firefly/Doodlebug pages
Verify images smaller than 512×512 can be uploaded via the Edit flow (reference image from device)
Verify images above maxFileSize (100MB) are still correctly rejected on both paths
Verify allowed file types (JPEG, PNG, WEBP) validation is still enforced
Verify Photoshop and Lightroom upload validation is unaffected
Jira
MWPW-190444

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 22, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@dstrong23
Copy link
Copy Markdown
Collaborator Author

@sanjayms01 sanjayms01 changed the title ADO-fix (MWPW-190444): remove 512x512 minimum dimension restriction for Fi… ADO-fix (MWPW-190444): remove 512x512 minimum dimension restriction for Firefly uploads May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants