[MWPW-194252] use common, localised default color palette name in toolbar#436
Open
[MWPW-194252] use common, localised default color palette name in toolbar#436
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"My Color Theme","Extracted Palette","Random Preset") in the toolbar, color-wheel, color-blindness, color-extract, and color-contrast-checker blocks''so the toolbar's existing localised placeholder (color-toolbar-palette-placeholder) is shown insteadgetPaletteWithNamefalls back tot.paletteNamePlaceholder(localised) when no name is typed, so share/download/save operations also use the localised stringColorThemeExpressControllernow receives the initial palette name so it persists across harmony-rule changesrandomPresetNameanddefaultPaletteNameplaceholder keys that were never consumed by their respective blocksJira Ticket
Resolves: MWPW-194252
Test URLs
Verification Steps
Potential Regressions
Additional Notes
(If applicable) Add context, related PRs, or known issues here.