Skip to content

[MWPW-194252] use common, localised default color palette name in toolbar#436

Open
vvineett wants to merge 1 commit intostagefrom
MWPW-194252-i18n-palette-name
Open

[MWPW-194252] use common, localised default color palette name in toolbar#436
vvineett wants to merge 1 commit intostagefrom
MWPW-194252-i18n-palette-name

Conversation

@vvineett
Copy link
Copy Markdown
Contributor

@vvineett vvineett commented May 4, 2026

Summary

  • Default palette/theme name is no longer hardcoded as an English string ("My Color Theme", "Extracted Palette", "Random Preset") in the toolbar, color-wheel, color-blindness, color-extract, and color-contrast-checker blocks
  • All defaults are now '' so the toolbar's existing localised placeholder (color-toolbar-palette-placeholder) is shown instead
  • getPaletteWithName falls back to t.paletteNamePlaceholder (localised) when no name is typed, so share/download/save operations also use the localised string
  • ColorThemeExpressController now receives the initial palette name so it persists across harmony-rule changes
  • Removed unused randomPresetName and defaultPaletteName placeholder keys that were never consumed by their respective blocks

Jira Ticket

Resolves: MWPW-194252


Test URLs

Env URL
Before https://main--express-color--adobecom.aem.page/create/image
After https://MWPW-194252-i18n-palette-name--express-color--adobecom.aem.page/create/image?martech=off
Before https://main--express-color--adobecom.aem.page/create/color-accessibility
After https://MWPW-194252-i18n-palette-name--express-color--adobecom.aem.page/create/color-accessibility?martech=off
Before https://main--express-color--adobecom.aem.page/create/color-contrast-analyzer
After https://MWPW-194252-i18n-palette-name--express-color--adobecom.aem.page/create/color-contrast-analyzer?martech=off
Before https://main--express-color--adobecom.aem.page/create/color-wheel
After https://MWPW-194252-i18n-palette-name--express-color--adobecom.aem.page/create/color-wheel?martech=off

Verification Steps

  • Steps to reproduce the issue or view the new feature.
  • What to expect before and after the change.

Potential Regressions

  • https://--da-express-milo--adobecom.aem.live/express/?martech=off

Additional Notes

(If applicable) Add context, related PRs, or known issues here.

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 4, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@github-actions github-actions Bot added the Ready for Review Ready for peer review. label May 4, 2026
@vvineett vvineett requested review from echen-adobe and nateyolles May 4, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Review Ready for peer review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant