Skip to content

DC Milo 0.2619#104

Open
Ruchika4 wants to merge 8 commits intomainfrom
stage
Open

DC Milo 0.2619#104
Ruchika4 wants to merge 8 commits intomainfrom
stage

Conversation

markovicpredrag1209 and others added 6 commits April 30, 2026 12:58
* publish tests v1

* playwright config revert

* disable acrobat standard

* refactor-start

* verb tests and nala lint

* test refactor

* lint

* wait added

* smaller gnav check

* load to domcontentloaded in verifyRedirect

* disable auto run of verb tests

* adding verifyAllCheckoutLinks to acrobat pages

* unity tests and assets for verbs

* baseurl fix

* adding nala instructions to readme

---------

Co-authored-by: Predrag Markovic <cod14230@adobe.com>
Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
* add support for mindmap-maker

* rename test file

* remove old test file

* remove maxFileSizeFriendly
@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 4, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 4, 2026

Page Scores Audits
📱 /acrobat/online/compress-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /acrobat/online/compress-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

tags: '@pdf-to-png @smoke @regression @unity',
},
],
}; No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <eol-last> reported by reviewdog 🐶
Newline required at end of file but not found.

Suggested change
};
};


await test.step('step-1: Go to PPT to PDF test page', async () => {
await page.goto(`${baseURL}${features[0].path}${unityLibs}`);
await page.waitForLoadState('domcontentloaded');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.

Suggested change
await page.waitForLoadState('domcontentloaded');
await page.waitForLoadState('domcontentloaded');

Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.29%. Comparing base (246cc5d) to head (16cd052).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   74.29%   74.29%           
=======================================
  Files          45       45           
  Lines        9604     9589   -15     
=======================================
- Hits         7135     7124   -11     
+ Misses       2469     2465    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* csp fix

* csp update

---------

Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants