Conversation
* publish tests v1 * playwright config revert * disable acrobat standard * refactor-start * verb tests and nala lint * test refactor * lint * wait added * smaller gnav check * load to domcontentloaded in verifyRedirect * disable auto run of verb tests * adding verifyAllCheckoutLinks to acrobat pages * unity tests and assets for verbs * baseurl fix * adding nala instructions to readme --------- Co-authored-by: Predrag Markovic <cod14230@adobe.com>
Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
* add support for mindmap-maker * rename test file * remove old test file * remove maxFileSizeFriendly
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
| tags: '@pdf-to-png @smoke @regression @unity', | ||
| }, | ||
| ], | ||
| }; No newline at end of file |
|
|
||
| await test.step('step-1: Go to PPT to PDF test page', async () => { | ||
| await page.goto(`${baseURL}${features[0].path}${unityLibs}`); | ||
| await page.waitForLoadState('domcontentloaded'); |
There was a problem hiding this comment.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Suggested change
| await page.waitForLoadState('domcontentloaded'); | |
| await page.waitForLoadState('domcontentloaded'); |
Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage 74.29% 74.29%
=======================================
Files 45 45
Lines 9604 9589 -15
=======================================
- Hits 7135 7124 -11
+ Misses 2469 2465 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* csp fix * csp update --------- Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DC Milo 0.2619
Description
Test URLs