Skip to content

MWPW-186525 Lingo Query Index for Plans and Catalog#925

Open
TsayAdobe wants to merge 4 commits intostagefrom
MWPW-186525
Open

MWPW-186525 Lingo Query Index for Plans and Catalog#925
TsayAdobe wants to merge 4 commits intostagefrom
MWPW-186525

Conversation

@TsayAdobe
Copy link
Copy Markdown
Collaborator

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Mar 11, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Mar 11, 2026

Page Scores Audits Google
📱 /creativecloud/plans?martech=off Lighthouse returned error: Something went wrong. PSI
🖥️ /creativecloud/plans?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@nkthakur48
Copy link
Copy Markdown
Collaborator

@raga-adbe-gh Could you please review these changes?

Comment thread helix-query.yaml
- /ca_fr/creativecloud/plans
- /ca_fr/creativecloud/plans/**
- /ca_fr/products/catalog
- /ca_fr/products/catalog/**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fragments need to be part of the Lingo query-index. Are the fragments used by these pages also under these paths?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sukamat Yes, shared assets and fragments are copied creativecloud/plans/merch-shared

@sukamat sukamat requested a review from vhargrave March 11, 2026 18:59
Comment thread helix-query.yaml
target: /cis_ru/cc-shared/assets/query-index-cards.xslx

lingo-mapping-ca_fr:
target: /ca_fr/creativecloud/plans/merch-shared/assets/lingo/query-index.xslx
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/creativecloud/plans.. appears to store index for both /ca_fr/creativecloud/plans and /ca_fr/products/catalog paths

Usually the index are placed in at root e.g. /cc-shared/assets should a similar be used e.g. /merch-shared/assets/ be used

cc: @nkthakur48

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raga-adbe-gh The shared folder will be creativecloud/plans/merch-shared

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is the way that lingo is built, it expects one primary query index for lingo per locale per project. The query indexes also have to live at a specific path like @raga-adbe-gh called out, because that contract makes link localization faster.
For now can we have these pages live in /cc-shared/assets/lingo until upp is ready to have its own query index?

Copy link
Copy Markdown
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, creativecloud/plans/merch-shared will need to be the new content root for these pages so that lingo can find the query index properly. Do you know if that's planned @nkthakur48 ? :/

@TsayAdobe
Copy link
Copy Markdown
Collaborator Author

also, creativecloud/plans/merch-shared will need to be the new content root for these pages so that lingo can find the query index properly. Do you know if that's planned @nkthakur48 ? :/

@vhargrave We are testing it out in the plans branch. https://plans--cc--adobecom.aem.page/creativecloud/plans
Once CC is migrated to da-cc, the changes should be merged into cc's stage and main.

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

4 similar comments
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@sukamat
Copy link
Copy Markdown
Contributor

sukamat commented Mar 21, 2026

@TsayAdobe @Blainegunn I see contentRoot update in the plans branch:

contentRoot: '/creativecloud/plans/merch-shared'

https://github.com/adobecom/cc/blob/plans/creativecloud/scripts/utils.js#L388

Questions:

  • Should this PR be merged to the plans branch?
  • Is the contentRoot path the final path that will eventually be merged to the stage/main branch of this repo? or will that path change post CC migration to DA?

cc: @vhargrave @raga-adbe-gh

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

1 similar comment
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

3 similar comments
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

6 similar comments
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@sukamat sukamat requested a review from raga-adbe-gh April 27, 2026 15:50
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

19 similar comments
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 925: MWPW-186525 Lingo Query Index for Plans and Catalog due to failing checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants