bump aws-sdk/client-s3 to 3.1045.0#238
Merged
Merged
Conversation
Resolves critical CVE-2026-25128 (GHSA-37qj-frw5-hhjh) — a RangeError DoS via malformed numeric entities in fast-xml-parser, affecting versions < 5.3.4.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pru55e11
approved these changes
May 8, 2026
Contributor
pru55e11
left a comment
There was a problem hiding this comment.
LGTM. Validated locally on the patch-1 branch:
- CVE fix confirmed —
npm ls fast-xml-parserresolves to5.7.2,npm auditreports 0 vulnerabilities at any severity. - No peer-dep drift —
@smithy/node-http-handlerdedupes to a single4.7.0across the entire tree, so the user-suppliedNodeHttpHandler(ProxyAgent)inlib/remote-storage.jsand the SDK's internal handler are the same module. No additional bump needed. - Unit tests + lint — 132/132 passing, 100% coverage, eslint clean.
- Real S3 round-trip via Adobe TVM — bundled the
e2e/sample-app, calleddeployWeb→listObjectsV2→undeployWeb→listObjectsV2against a real workspace. 5 objects uploaded viaputObject, all 5 removed bydeleteObjects, post-undeployKeyCount=0. The new SDK defaultrequestChecksumCalculation: 'WHEN_SUPPORTED'is accepted by TVM-fronted S3 with no issues. - e2e flake —
npm run e2efails theundeploytest withexpected 404, got 200, but that's CDN cache (s-maxage=60set on deploy, fetch happens ~1.7s later). Direct S3 listing after undeploy is empty, so the SDK is fine. Pre-existing, unrelated.
Approving.
shazron
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves critical CVE-2026-25128 (GHSA-37qj-frw5-hhjh) — a RangeError DoS via malformed numeric entities in fast-xml-parser, affecting versions < 5.3.4.
Description
Bumps
@aws-sdk/client-s3to3.1045.0, which transitively pulls in@aws-sdk/xml-builder@3.972.22→fast-xml-parser@5.7.2, resolving the critical vulnerability present in the previously pinnedfast-xml-parser@5.2.5.Related Issue
Resolves CVE-2026-25128 / GHSA-37qj-frw5-hhjh
Motivation and Context
fast-xml-parser@5.2.5(pulled in via@aws-sdk/xml-builder@3.965.0) contains a critical RangeError Denial-of-Service vulnerability triggered by malformed numeric entities in XML input. An attacker able to supply crafted XML payloads could crash the Node.js process. Upgrading@aws-sdk/client-s3to3.1045.0resolves the full vulnerability chain.Dependency chain before:
Dependency chain after:
How Has This Been Tested?
npm install --dry-runconfirmingfast-xml-parser@5.7.2is installed.@aws-sdk/xml-builder@3.972.22shipsfast-xml-parser@5.7.2vianpm info.Screenshots (if appropriate):
N/A
Types of changes
Checklist: