Skip to content

feat: support nodejs:26 kind to the list of supported runtimes#232

Merged
mgar merged 1 commit into
masterfrom
node-26
May 27, 2026
Merged

feat: support nodejs:26 kind to the list of supported runtimes#232
mgar merged 1 commit into
masterfrom
node-26

Conversation

@mgar

@mgar mgar commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds nodejs:26 to the static SupportedRuntimes list (src/utils.js) and the corresponding validateActionRuntime test (test/utils.test.js).

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mgar
feat: support nodejs:26 kind to the list of supported runtimes
9b89089 
Adds nodejs:26 to the static SupportedRuntimes list (src/utils.js) and
the corresponding validateActionRuntime test (test/utils.test.js).

Mirrors PR #223 (Node 24) exactly.

Refs ACNA-4591
github-actions[bot]
github-actions Bot approved these changes May 27, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 PR Reviewer

Simple and clean addition of nodejs:26 to the supported runtimes list with a corresponding test case. The change is minimal, consistent with the existing pattern, and properly tested.

✅ LGTM! This PR looks good to merge.

💡 How to re-trigger

Comment /review or /pr-reviewer on this PR

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

pru55e11
pru55e11 approved these changes May 27, 2026
View reviewed changes

@pru55e11 pru55e11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list is getting long lol 😳

@dthampy

dthampy commented May 27, 2026

Copy link
Copy Markdown
Contributor

The list is getting long lol 😳

While Michael was working on adding node22, there was this conversation around removing older versions like 10, 12 etc. But never happened.
As we keep adding more node versions, it also added more version specific concurrent tests to the matrix. So during the node24 work, we ended up capping the the requestCount to keep the tests passing

@mgar mgar merged commit 6248dc2 into master May 27, 2026
11 checks passed
@mgar mgar deleted the node-26 branch May 27, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@purplecabbage purplecabbage purplecabbage approved these changes

@pru55e11 pru55e11 pru55e11 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@MichaelGoberling MichaelGoberling Awaiting requested review from MichaelGoberling

@dthampy dthampy Awaiting requested review from dthampy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgar @dthampy @purplecabbage @pru55e11