Repository navigation
fix: protect null values for license config checks, consider cred type when checking for dupe sdks - #55
Merged
Conversation
MichaelGoberling
commented
Mar 27, 2026
Contributor
- Do a null check on license configs property from dev console before trying to set when subscribing
- Handle duplicate sdk codes (both adobeid and entp) when trying to set license configs
…e when checking for dupe sdks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR hardens API subscription configuration against null/ambiguous service catalog entries by (1) guarding against properties: null when filtering license configs and (2) disambiguating org-catalog service definitions by service type (entp vs adobeid) when the same code exists under multiple credential types.
Changes:
- Pass
serviceTypeintogetServicesInfoand use it to select the correct org-catalog row when a servicecodeappears under multiple types. - Add a null-guard before writing
orgServiceDefinition.properties.licenseConfigswhenpropertiesis null. - Add tests covering
properties: nulland dual-type catalog scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/lib/configure-apis.js |
Adds serviceType disambiguation when resolving service definitions and guards against null properties during license config filtering. |
test/lib/configure-apis.test.js |
Adds regression tests for null properties and for services that appear under both adobeid and entp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
purplecabbage
approved these changes
Mar 27, 2026
purplecabbage
left a comment
There was a problem hiding this comment.
copilot has some testing nits to look at
pru55e11
approved these changes
Mar 27, 2026
shazron
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.