poetry: unlock cryptography versions to prevent conflicts with other packages#115
Open
markjm wants to merge 1 commit intoadobe-apiplatform:v3from
Open
poetry: unlock cryptography versions to prevent conflicts with other packages#115markjm wants to merge 1 commit intoadobe-apiplatform:v3from
markjm wants to merge 1 commit intoadobe-apiplatform:v3from
Conversation
Author
|
Hi @adorton-adobe - thanks for maintaining the project. I have created a small PR which i think demonstrates a problem and fixes it. Please let me know if there is anything else youd like from me for validation or process! |
4b027d7 to
dd7725d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, cryptography is pinned to
cryptography = "^38.0.4". In poetry, this expands to>=38.04,<39.This worked well for old cryptography package versions since they always looked like
3.X.Y, but starting in35.*versioning changed.See https://cryptography.io/en/latest/api-stability/#versioning for specifics - essentially a major version change does not indicate breaking changes necessarily.
Testing
Running tests on latest
cryptographyright now (40), all tests passAdditionally, a random sampling of 3p dependencies used in a random internal project seems to indicate that this is standard practice

Note - I have signed the CLA on behalf of my company, tied to my github username @markjm