Limit damage values for emergency teams and civilians to 10000#142
Merged
Limit damage values for emergency teams and civilians to 10000#142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a safeguard to cap the
damageattribute for various agent message classes at a maximum value of 10,000. This ensures that damage values do not exceed this upper limit, likely to prevent unrealistic or erroneous data from propagating through the system.Damage value capping across agent message classes:
damageat 10,000 forAmbulanceTeammessages inmessage_ambulance_team.py(src/adf_core_python/core/agent/communication/standard/bundle/information/message_ambulance_team.py).damageat 10,000 forCivilianmessages inmessage_civilian.py(src/adf_core_python/core/agent/communication/standard/bundle/information/message_civilian.py).damageat 10,000 forFireBrigademessages inmessage_fire_brigade.py(src/adf_core_python/core/agent/communication/standard/bundle/information/message_fire_brigade.py).damageat 10,000 forPoliceForcemessages inmessage_police_force.py(src/adf_core_python/core/agent/communication/standard/bundle/information/message_police_force.py).